fix: compare BASE with merged state instead of HEAD directly #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #11, where the action incorrectly indicated that changes to the BASE branch would be reverted when the PR is merged.
Problem
The previous implementation compared the kustomize output from the BASE branch directly with the HEAD branch. This approach fails to account for git's merge behaviour and can lead to misleading diffs:
When someone creates a feature branch without first pulling the latest changes, parallel changes made to BASE would appear as if they would be reverted by the PR, even though git's actual merge behavior would preserve them.
Solution
Instead of comparing BASE with HEAD directly, this PR:
This approach shows only the changes introduced by merging the PR, providing a more accurate representation of the final state.
Additional Improvements
Closes #11
How has this been tested?
Types of changes
Checklist:
git commit -s