Skip to content

Diff might be inaccurate if BASE contains changes that aren't on HEAD #11

Closed
@joshgubler

Description

@joshgubler

If a change is made to the BASE branch in parallel to the HEAD branch, the diff from this module indicates that the change will be reverted. Git, however, is smart enough to know that the change should not be reverted when the PR is merged.

Old Base -> BASE
         \
           -> HEAD

It's very easy to get into this state if the person creating the PR doesn't git pull before creating their feature branch.

Rather than comparing the output from kustomize on BASE with the output on HEAD, it would be better to compare the output on BASE with the output after merging HEAD to BASE. Obviously, this merge should only happen locally on the runner and not be pushed.

Metadata

Metadata

Assignees

Labels

enhancementNew feature or requestquestionFurther information is requestedreleased

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions