-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor JS lib to use our new codegen #1700
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64a8903
to
f07beda
Compare
svix-lucho
reviewed
Feb 5, 2025
svix-lucho
reviewed
Feb 5, 2025
svix-lucho
reviewed
Feb 5, 2025
Open source reviewDev dependency Replace
With |
9f2bfa4
to
eb0a634
Compare
Open source reviewDev dependency https://github.com/httptoolkit/mockttp
Used to test that out going requests are de/serialized correctly |
3496cc4
to
81e8168
Compare
650f929
to
7eda6b3
Compare
Also add dependency on mockttp
9fac4e3
to
f48c73b
Compare
28590d2
to
6930222
Compare
svix-lucho
reviewed
Feb 19, 2025
svix-lucho
reviewed
Feb 19, 2025
For some reason Date was hard-coded to always be `Date | null` And since I have tests for Date de/serialization, I am confident I can remove this
svix-lucho
reviewed
Feb 19, 2025
svix-lucho
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
src/index.ts
Currently if the server omits a field from the response body, the json deserialization wont fail. And anyone using the js/ts lib will just get
undefined
if they try to access that fieldBreaking changes
endpoint.oauthUpdate
andendpoint.oauthDelete
are no longer generatedMessageAttempt.list
is removedwebhook.ts
New resources
I figured since they are publicly documented in api.svix.com/docs we should add them here.
ref: