js: Add type templates #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svix-jplatte
force-pushed
the
jplatte/js-type-tpl
branch
from
8cb7cd9 to
c3e54a2
Compare
svix-mman
force-pushed
the
jplatte/js-type-tpl
branch
4 times, most recently
from
4beca9d to
f0d09e8
Compare
Open source reviewbiome Javascript/Typescript formatter Main advantage over prettier, biome can remove unused imports.
|
svix-mman
force-pushed
the
jplatte/js-type-tpl
branch
2 times, most recently
from
2082dc0 to
3ce926a
Compare
svix-mman
approved these changes
Feb 19, 2025
|
Don't merge, waiting for Jonas to review |
svix-jplatte
commented
Feb 24, 2025
svix-jplatte
commented
Feb 24, 2025
Comment on lines
13
to
15
| {% else -%} | ||
| {# technically a compiler error :) #} | ||
| compile_error!("{{ type.kind }} types are not supported by this codegen template"); |
There was a problem hiding this comment.
Copy-paste from Rust, I'd rather not have it like this. Although if there's a TS equivalent, would be nice to add.
Suggested change
| {% else -%} | |
| {# technically a compiler error :) #} | |
| compile_error!("{{ type.kind }} types are not supported by this codegen template"); |
There was a problem hiding this comment.
Still technically a compiler error :)
src/example.ts:1:1 - error TS2304: Cannot find name 'compile_error'.
1 compile_error!("{{ type.kind }} types are not supported by this codegen template");
~~~~~~~~~~~~~
d60b94d to
3eb1c47
Compare
Co-authored-by: Mendy Man <[email protected]>
Co-authored-by: Mendy Man <[email protected]>
svix-jplatte
force-pushed
the
jplatte/js-type-tpl
branch
from
3eb1c47 to
139e119
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
almost working. I've explained @svix-lucho the state of things so this can be finished while I'm away.
Reflected in svix/svix-webhooks#1700.