python: Replace OpenAPI generator http code with out own #1654

svix-mman · 2025-01-20T22:09:59Z

Switching the HTTP call logic with a single (a)sync function.

WIP:

Don't use the old internal.openapi_client error types
Migrate the resources to use this new client

ref: https://github.com/svix/monorepo-private/issues/9685

python/svix/api/application.py

…params` `_query_params` and `_header_params` should return values that are ready to use _as is_ in `httpx.request`

python/svix/api/application.py

python/svix/api/common.py

This is what we call this in rust/old openapi codegen

python/svix/api/common.py

Co-authored-by: Tom Hacohen <[email protected]>

…no query/header params

…`*Options` dataclasses

python/svix/api/common.py

…point`methods from `MessageAttempt` And remove `list_attempts_for_endpoint` from `MessageAttemptAsync`

…` methods to `MessageAttempt(A)sync` Not sure why these _new_ methods have deprecated in their name

svix-mman · 2025-01-21T16:47:27Z

@tasn The last 2 commits are breaking change, but they add new methods that are deprecated, and the methods have "deprecated" in the method name
This feels wrong to me, we should not be adding new methods that are already deprecated

The reason we only get this change now (instead of when I was working on the high-level API), is because I am working with a new openapi.json file

…e new codegen

python/svix/api/application.py

python/svix/api/authentication.py

python/svix/api/background_task.py

tasn · 2025-01-22T13:26:57Z

@tasn The last 2 commits are breaking change, but they add new methods that are deprecated, and the methods have "deprecated" in the method name This feels wrong to me, we should not be adding new methods that are already deprecated

The reason we only get this change now (instead of when I was working on the high-level API), is because I am working with a new openapi.json file

Whatever @svix-jplatte thinks is fine by me.

…rywhere

They were never part of the old python API, so this is not a breaking change. These operations were briefly; but are no longer included as part of the `openapi.json`

Co-authored-by: Jonas Platte <[email protected]>

svix-mman added 3 commits January 20, 2025 17:06

python: Add new low-level http client

cbd1f89

python: Migrate Application to new HTTP client

cca4e24

python: Sort dashboard_access in the correct order

14e8d0f

tasn reviewed Jan 20, 2025

View reviewed changes

python/svix/api/application.py Outdated Show resolved Hide resolved

tasn reviewed Jan 20, 2025

View reviewed changes

python/svix/api/application.py Outdated Show resolved Hide resolved

svix-mman added 2 commits January 20, 2025 17:36

python: Rename query_params/header_params to an internal method

97893a3

python: Add sanitize_field and str().lower() in `*Options._query_…

8255e3a

…params` `_query_params` and `_header_params` should return values that are ready to use _as is_ in `httpx.request`

tasn reviewed Jan 20, 2025

View reviewed changes

python/svix/api/application.py Outdated Show resolved Hide resolved

tasn reviewed Jan 20, 2025

View reviewed changes

python/svix/api/common.py Outdated Show resolved Hide resolved

svix-mman added 2 commits January 21, 2025 09:40

python: For now we only need 1 exception type for HTTP errors

f4bb9c5

python: rename _execute_request to _request

60750da

This is what we call this in rust/old openapi codegen

tasn reviewed Jan 21, 2025

View reviewed changes

python/svix/api/common.py Outdated Show resolved Hide resolved

tasn reviewed Jan 21, 2025

View reviewed changes

python/svix/api/common.py Outdated Show resolved Hide resolved

svix-mman added 2 commits January 21, 2025 10:20

python: Add serialize_params to _query_params/_header_params

67155e6

python: Simplify path param url formatting

be34bba

tasn reviewed Jan 21, 2025

View reviewed changes

python/svix/api/common.py Outdated Show resolved Hide resolved

svix-mman and others added 5 commits January 21, 2025 10:28

python: Explicit boolean serialization

f0c4a6c

Co-authored-by: Tom Hacohen <[email protected]>

python: Don't generate _query_params/_header_params if there are …

7de109c

…no query/header params

python: Implement a default _header_params and _query_params for …

c93c0d1

…`*Options` dataclasses

python: _query_params and _header_params need self (:

04ec169

python: Switch Authentication to new HTTP client

ddc30ad

tasn reviewed Jan 21, 2025

View reviewed changes

python/svix/api/common.py Show resolved Hide resolved

svix-mman added 7 commits January 21, 2025 10:56

python: Switch BackgroundTask to new codegen

a4970e3

python: Switch Endpoint resource to new HTTP client

072091f

python: Switch EventType resource to new HTTP client

6e23c1f

python: Mark Integration(A)sync.get_key as deprecated

1d4c76a

python: Switch the Integration resource to new HTTP client

e992a60

python(**Breaking change**): Remove list and `list_attempts_for_end…

ec8092e

…point`methods from `MessageAttempt` And remove `list_attempts_for_endpoint` from `MessageAttemptAsync`

python: Add list_by_msg_deprecated and `list_by_endpoint_deprecated…

6374d5c

…` methods to `MessageAttempt(A)sync` Not sure why these _new_ methods have deprecated in their name

python: Switch Message resource to use new HTTP client

3e0a99f

svix-mman mentioned this pull request Jan 21, 2025

python: Move OperationalWebhook to new codegen #1656

Merged

svix-mman added 5 commits January 21, 2025 13:55

python: Switch Statistics to new HTTP client

cd36ffb

python: remove PostOptions from OperationalWebhook

f9b9d16

python: Rename operational_webhook to operational_webhook_endpoint

da78242

python: (breaking change) Rename these arguments to be inline with th…

6b7ca26

…e new codegen

python: Switch OperationalWebhookEndpoint to new HTTP client

2018317

svix-jplatte reviewed Jan 22, 2025

View reviewed changes

python/svix/api/application.py Show resolved Hide resolved

python/svix/api/authentication.py Outdated Show resolved Hide resolved

python/svix/api/authentication.py Show resolved Hide resolved

python/svix/api/background_task.py Show resolved Hide resolved

svix-mman added 6 commits January 22, 2025 08:41

python: Codegen is smart enough to not need to leave noqa: F841 eve…

0071e10

…rywhere

python: Better codegen does not need to ignore unused variable warnings

03a6f7b

python: This is the correct way to handel class properties doc comments

ecb9202

python: Document breaking changes

1c05e65

python: Remove these deprecated operations.

1b5545e

They were never part of the old python API, so this is not a breaking change. These operations were briefly; but are no longer included as part of the `openapi.json`

python: Update generated files to use correct doc string format

ea02fe7

svix-mman marked this pull request as ready for review January 23, 2025 02:57

svix-mman requested a review from a team as a code owner January 23, 2025 02:57

svix-mman and others added 3 commits January 23, 2025 08:40

This was not really a breaking change

10942df

English: Correct syntax error...

348fcc1

Co-authored-by: Jonas Platte <[email protected]>

python: Move OperationalWebhook to new codegen (#1656)

db7adbe

svix-jplatte previously approved these changes Jan 23, 2025

View reviewed changes

Merge branch 'main' into mendy/add-python-low-level-http-client

0277b9f

svix-mman mentioned this pull request Jan 23, 2025

python: Switch to explicit import for custom types #1661

Closed

python: Sort these method inline with the codegen

f165777

svix-mman dismissed svix-jplatte’s stale review via f165777 January 23, 2025 17:48

python: Serialize list/set params as a comma separated list

8f204c7

svix-jplatte approved these changes Jan 23, 2025

View reviewed changes

svix-jplatte changed the title ~~python: Add new low-level http client~~ python: Replace OpenAPI generator http code with out own Jan 23, 2025

svix-jplatte merged commit 344d258 into main Jan 23, 2025
8 checks passed

svix-jplatte deleted the mendy/add-python-low-level-http-client branch January 23, 2025 19:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

python: Replace OpenAPI generator http code with out own #1654

python: Replace OpenAPI generator http code with out own #1654

svix-mman commented Jan 20, 2025

svix-mman commented Jan 21, 2025 •

edited

Loading

tasn commented Jan 22, 2025

python: Replace OpenAPI generator http code with out own #1654

python: Replace OpenAPI generator http code with out own #1654

Conversation

svix-mman commented Jan 20, 2025

svix-mman commented Jan 21, 2025 • edited Loading

tasn commented Jan 22, 2025

svix-mman commented Jan 21, 2025 •

edited

Loading