Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: Switch to explicit import for custom types #1661

Closed
wants to merge 4 commits into from
Closed

python: Switch to explicit import for custom types #1661

wants to merge 4 commits into from

Conversation

svix-mman
Copy link
Contributor

@svix-mman svix-mman commented Jan 23, 2025 •
edited
Loading

Before I get working on generating the models, I want this ready first

@svix-mman svix-mman requested a review from a team as a code owner January 23, 2025 17:23
svix-jplatte
svix-jplatte reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@svix-jplatte svix-jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we doing this? I think I left a comment before on the template side already a few days ago, because we are relying on ruff fixing up otherwise invalid code there and I don't understand why we wouldn't just keep doing models.Type.

@svix-mman
Copy link
Contributor Author

@svix-jplatte I guess this PR is not really needed, Let's merge it into #1654

@svix-jplatte
Copy link
Member

Okay.

@svix-jplatte svix-jplatte deleted the mendy/dont-import-using-models-dot branch January 23, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svix-jplatte svix-jplatte svix-jplatte left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svix-mman @svix-jplatte