Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(render/dot): handles notes on composite self-transitions #223

Merged

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Dec 24, 2024

Description

  • handles notes on composite self-transitions

Motivation and Context

Notes were handled, as were composite self-transitions. The combination never was, so self-transitions with a note didn't get a special treatment - see the before in the screenshots section.

How Has This Been Tested?

  • green ci
  • additional non-regression test

Screenshots

Given this self-transition, without a note ...

without-a-note

... adding a note ...

After this PR

after

Before this PR

before

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

Copy link

codeclimate bot commented Dec 24, 2024

Code Climate has analyzed commit 76e86bd and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@sverweij sverweij merged commit e071d51 into main Dec 24, 2024
11 checks passed
@sverweij sverweij deleted the fix/make-notes-on-composite-self-transitions-look-better branch December 24, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant