Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamline and simplify CI building #880
Streamline and simplify CI building #880
Changes from 32 commits
e888f32
3de7026
ecbc650
26254d7
89f5ab7
23f681a
901d290
6932898
3f221ea
398be8c
18f13de
eb50145
9734b55
b57e445
9c08669
1de8a71
0de1bb4
584f977
d56cd76
3961006
cfe32d5
f3de165
1ca8cb6
41618ec
26d234a
c238d5e
f22c535
9ad1611
8d94528
b75e6bf
14fab28
7f48fbc
cac65e6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it worth testing here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's in the next step of this job - do you think there is a reason to move it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking it could save a few lines of yaml, in particular that env varible called $GITHUB_WORKSPACE would not be needed