-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sidebars ablog translations (#80) #161
Conversation
Hmm.. there's a failure in the PR checks. Any idea what that means? |
You can ignore For |
Thanks for the PR! I can test it if you want to see if it works? Is there something else you want do before this is ready? |
Thanks for the PR! I can test it if you want to see if it works?
Yes, please do test it. Any feedback is welcome as this is something out
of my comfort zone :-)
Is there something else you want do before this is ready?
Actually, I had another local change I forgot to commit. Unfortunately, I
won't be able to do that now -- I'll try to push it later today. It's
simply an update to the documentation, that needs to be updated.
|
Take your time, there is no need to rush here! |
Ok, I've just pushed the extra change I had. It's a trivial change, I believe. Just update documentation to use the correct file paths. Please let me know if you see any issues with this pull-request, specially with the commit that fixes issue #80 which is the one I'm less comfortable with. |
Signed-off-by: Luís Henriques <[email protected]>
Signed-off-by: Luís Henriques <[email protected]>
With commit 4aa0e52 ("moved files to correct place") the localization files have been moved from 'ablog/locale/' to 'ablog/locales'. Fix the documentation, which still refers to the old path. Signed-off-by: Luís Henriques <[email protected]>
Sorry for not getting back sooner, as far as I can tell, it works! Thank you very much. |
Co-authored-by: Luís Henriques <[email protected]> Co-authored-by: Nabil Freij <[email protected]>
This pull-request includes 2 commits:
I'm leaving this as a draft pull-request. Comments are welcome.