Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pagination for Partition Table #1302

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Add pagination for Partition Table #1302

merged 3 commits into from
Dec 12, 2024

Conversation

hemahg
Copy link
Contributor

@hemahg hemahg commented Dec 11, 2024 •
edited
Loading

Add pagination for Partition Table

Related to issue #1249

@hemahg hemahg marked this pull request as draft December 11, 2024 11:50
@hemahg hemahg changed the title [WIP] Add pagination Add pagination Dec 11, 2024
@hemahg hemahg marked this pull request as ready for review December 11, 2024 12:18
@MikeEdgar MikeEdgar linked an issue Dec 11, 2024 that may be closed by this pull request
Pagination on Topic Partitions tab does not work #1249
Closed
@MikeEdgar MikeEdgar changed the title Add pagination Add pagination for Partition Table Dec 12, 2024
@MikeEdgar MikeEdgar added this to the 0.6.0 milestone Dec 12, 2024
MikeEdgar
MikeEdgar requested changes Dec 12, 2024
View reviewed changes
Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one issue with changing the page size.

ui/app/[locale]/(authorized)/kafka/[kafkaId]/topics/[topicId]/partitions/PartitionsTable.tsx Outdated Show resolved Hide resolved
@hemahg
Add pagination
d7258e2 
Signed-off-by: hemahg <[email protected]>
@hemahg
Add pagination
4008aaf 
Signed-off-by: hemahg <[email protected]>
@hemahg
Incorporate review comment
1ba5ac3 
Signed-off-by: hemahg <[email protected]>
MikeEdgar
MikeEdgar approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hemahg

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@MikeEdgar MikeEdgar merged commit bdf12f5 into main Dec 12, 2024
9 checks passed
@MikeEdgar MikeEdgar deleted the add-pagination branch December 12, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeEdgar MikeEdgar MikeEdgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

Pagination on Topic Partitions tab does not work
2 participants
@hemahg @MikeEdgar