Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination on Topic Partitions tab does not work #1249

Closed
MikeEdgar opened this issue Nov 27, 2024 · 3 comments · Fixed by #1302
Closed

Pagination on Topic Partitions tab does not work #1249

MikeEdgar opened this issue Nov 27, 2024 · 3 comments · Fixed by #1302
Labels
bug Something isn't working ui

Comments

@MikeEdgar
Copy link
Member

The pagination controls are displayed, but they do not do anything when clicked.

image

@MikeEdgar MikeEdgar added bug Something isn't working ui labels Nov 27, 2024
@MikeEdgar MikeEdgar linked a pull request Dec 3, 2024 that will close this issue
@hemahg
Copy link
Contributor

hemahg commented Dec 3, 2024

The backend does not currently support pagination for the partitions table. If pagination is necessary, we can implement it on the frontend. Alternatively, we could consider removing pagination from the partitions table altogether. What are your thoughts on the best approach?

@MikeEdgar MikeEdgar removed a link to a pull request Dec 3, 2024
@MikeEdgar
Copy link
Member Author

Ah, right. I forgot that the partitions are embedded in the topic response. Maybe having front-end pagination would be better than removing it altogether. If we decide to implement it in the API later, it would be the same UX.

@MikeEdgar
Copy link
Member Author

I think it's probably OK to just remove the pagination controls for now too. Whatever is easier really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants