Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Add per chain and node metrics #198

Conversation

Gustavobelfort
Copy link
Contributor

@Gustavobelfort Gustavobelfort commented Sep 11, 2023

Summary

This Pull Request introduces per-chain and per-node metrics collection into the Horcrux monitoring system. The main objective of this update is to enhance system observability, enabling a deeper insight into the individual performance of each node and chain. This is instrumental for network health assessment, debugging, and performance optimization.

Background

Prior to this PR, Horcrux only provided global metrics which made it challenging to debug issues on a per-node or per-chain basis. As Horcrux networks can be composed of multiple chains and nodes, a granular level of metrics is essential for operational excellence.

Changes

  • New Labels collection in the metrics that might pertain to multiple chains and/or signer (sentry) nodes

As this is an extension of the existing metrics collection, it does not require special migration steps. However, due to the label changes, ensure compatibility with dependent services and tests.

@Reecepbcups Reecepbcups linked an issue Oct 23, 2023 that may be closed by this pull request
@agouin agouin mentioned this pull request Nov 16, 2023
@agouin
Copy link
Member

agouin commented Nov 17, 2023

Thank you for this! Merged in #219 and will be included in the v4 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: metrics should have 'chain-id' where feasible
2 participants