Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: metrics should have 'chain-id' where feasible #204

Closed
PFC-developer opened this issue Sep 25, 2023 · 1 comment
Closed

Comments

@PFC-developer
Copy link

in my configuration I have multiple horcrux services running (I deploy 1 horcrux service for each chain, not 1 horcrux service for ALL chains).

it would be nice to be able to specify a 'chain_id' or some custom label similar to how cosmos does.

for example:

global-labels = [
["chain_id","migaloo-1"],
]

it also looks like horcrux creates metrics with the hostname embedded into them.
for example

horcrux_andromeda_horcrux_0_runtime_alloc_bytes

shouldn't it just do
horcrux_runtime_alloc_bytes ?

@Reecepbcups Reecepbcups linked a pull request Oct 23, 2023 that will close this issue
@agouin
Copy link
Member

agouin commented Nov 17, 2023

Resolved by #198 #219

@agouin agouin closed this as completed Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants