Core: Add highlight.js to es6 transpiled modules #12811
Conversation
|
@gaetanmaisse any idea on fixing yarn 2 while keeping the highlight.js transpilation ? |
| @@ -3,7 +3,7 @@ import { plugins } from './babel'; | |||
| const es6Transpiler = () => { | |||
| // TODO: generate regexp using are-you-es5 | |||
|
|
|||
| const include = /[\\/]node_modules[\\/](@storybook\/node-logger|are-you-es5|better-opn|boxen|chalk|commander|find-cache-dir|find-up|fs-extra|json5|node-fetch|pkg-dir|resolve-from|semver)/; | |||
| const include = /[\\/]node_modules[\\/](@storybook\/node-logger|are-you-es5|better-opn|boxen|chalk|commander|find-cache-dir|find-up|fs-extra|highlight.js|json5|node-fetch|pkg-dir|resolve-from|semver)/; | |||
There was a problem hiding this comment.
Done but still not working in yarn 2 :(
tooppaaa
force-pushed
the
fix/ie11Highlightjs
branch
from
9cd727c to
46655a4
Compare
|
LGTM! I'm not sure if there are possible side effects to this but seems solid. Of course there has to be some documentation as well, maybe on FAQ? |
|
Just waiting to be sure we want to go to the path of adding options like this in main.js @shilman @tmeasday @ndelangen ? I'm sure @jonniebigodes will be able to point me the right direction for documenting this after :D |
|
I thought we used prism for code highlighting rather than highlight? where are we using highlight? |
|
@tooppaaa let me know when you have something created and we can go from there. Sounds good? |
Don't know but it's definitely present in the bundles. |
|
IE 11 is working ! not needed ! |
Issue: IE 11, #12399 #12179
What I did
Transpile highlight.js
How to test