Version 6.1.0-alpha.0 doesn’t work in IE11 because of highlight dependence

[pavel-sindelka]

Describe the bug

Stroybook 6.1.0-alpha.0 depends on react-syntax-highlighter 13.2.1 which depends on highlight ^10.1.1 and lowlight ^1.14.0 dependencies but according to the changelog of highlight IE11 will no longer be supported

"We're now using ES2015 features in the codebase. Internet Explorer 11 is no longer supported."

Screenshots

[fernandopasik]

would it be possible to understand if a polyfill is needed for ie11 or something?
Could you post the errors in english as well please?

[fernandopasik]

BTW the upgrade was necessary because of a security issue.

[pavel-sindelka]

Its syntax error because IE 11 cant interpret classes

[fernandopasik]

might need to pass the library by the babel config, maybe there's a place we can add that in storybook babel config

@shilman any hint where that could be?

[shilman]

@tooppaaa and @ndelangen worked on recompiling some storybook dependencies for IE compatibility. Hopefully they can lend a hand here.

[tooppaaa]

If someone has a chance to look at it before me, probably a dependency needs to be added to this regexp:
https://github.com/storybookjs/storybook/blob/next/lib/core/src/server/common/es6Transpiler.js

[tooppaaa]

obahareth/are-you-es5#53

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[fernandopasik]

sounds like from this comment #12811 (comment) this issue was resolved @tooppaaa ?

[fernandopasik]

@pavel-sindelka have you tried again with the latest version of storybook?

[diogofscmariano]

This introduced a breaking change in a minor version and I think the commit 781c2ae should just be reverted.
Meanwhile, we will revert to the latest 6.0.x while the is no update on this.

[tooppaaa]

@pavel-sindelka have you tried again with the latest version of storybook?

Same thing @diogofscmariano, it should work without any change on your side.

[fernandopasik]

@diogofscmariano it wasn't just because the change, there were security vulnerabilities with the dependencies.

It wasn't a breaking change as the work was done to reach feature parity. There was just an issue with IE11 and from #12811 (comment) looks like it's resolved.

Are you still having problems with it?

[jackysee]

The fix mention in #12948 is not on the 6.1.x release branch.

[shilman]

@jackysee does 6.2 alpha work for you?

[jackysee]

Unfortunately, 6.2 alpha has problem #13562 in IE11. Should be related to addon-docs

[tooppaaa]

This issue is now quite old and is fixed if I'm not mistaken.
@jackysee, if there's still something not working with the released 6.2, please create a new issue :)