Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: try to improve error handling logic in unixfs streams #1261

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Commits on Jan 17, 2024

  1. fix: try to improve error handling logic in unixfs streams

    right now errors in the `finalize` methods can leave a writer unclosed forever - this should help improve the DX issues described in storacha/console#81 (comment) by at least printing an error to the console with information about the problem
    travis committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    7f9c925 View commit details
    Browse the repository at this point in the history
  2. fix: lint

    travis committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    ed2b9b2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bd9da8e View commit details
    Browse the repository at this point in the history
  4. fix: lint

    travis committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    2cfa58b View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. fix: use abort instead of squashing error

    confirmed this results in better behavior in the web console! was also able to test the error path here - I tried to create a `File` that represents a directory like in runtime error but could not reproduce - that seems to be a weird edge case that is hard to reproduce outside the browser context
    travis committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    824ed12 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    91ea671 View commit details
    Browse the repository at this point in the history