Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: try to improve error handling logic in unixfs streams #1261

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: try to improve error handling logic in unixfs streams #1261

wants to merge 6 commits into from

Conversation

travis
Copy link
Member

@travis travis commented Jan 17, 2024

right now errors in the finalize methods can leave a writer unclosed forever - this should help improve the DX issues described in storacha/console#81 (comment) by at least printing an error to the console with information about the problem

@travis
fix: try to improve error handling logic in unixfs streams
7f9c925 
right now errors in the `finalize` methods can leave a writer unclosed forever - this should help improve the DX issues described in storacha/console#81 (comment) by at least printing an error to the console with information about the problem
@travis travis requested review from alanshaw, Gozala, gobengo and olizilla and removed request for alanshaw January 17, 2024 00:41
alanshaw
alanshaw requested changes Jan 18, 2024
View reviewed changes
packages/upload-client/src/unixfs.js Outdated Show resolved Hide resolved
travis and others added 2 commits January 18, 2024 16:24
@travis
fix: use abort instead of squashing error
824ed12 
confirmed this results in better behavior in the web console! was also able to test the error path here - I tried to create a `File` that represents a directory like in runtime error but could not reproduce - that seems to be a weird edge case that is hard to reproduce outside the browser context
@travis
Merge branch 'main' into fix/unixfs-stream-errors
91ea671
@travis travis requested a review from alanshaw January 19, 2024 00:26
@Gozala
Copy link
Contributor

Gozala commented Jan 25, 2024

I think we could add utility function along the following lines

image

https://www.typescriptlang.org/play?#code/C4TwDgpgBAShDOBXANsAPAFShAHsCAdgCbxQDeAvlALzkUA0UAGtnoSXTVAKIBOvAe14A+GgCgokqAB9yUAQGsAXFAyMI-IQH4VBCADcNUChKmyy8hTqh7DvdZt4qWJsW7cBLAvl4AzAIYAxtBw-kR8grys+MSkEULkppIE-gC2ECoA5KHhjplirl4+AcFQAOq8HvjxUbgxHDWJUjZpGVCZFVUQNfmuRBCByP680L6IBIHAHgIEUCNhABRg-sAAFkrwwJUEAOYAlCpwSKhoAKpFABwAgvz+IIw5NcJi-YPDo+OT07MA7pX4SxW6ygm22O0YRBW-hU52811uIAOsAQKHQlEYnWqjmeYkCM02ql4IC4aBg0XYpCOqMYWDqFLojBYdNiPEcXFsGmECzeiHgbQWexoogA4oQNCshKSHiiTmpmMJhAcqbLGAsYABtTIaSKZAC6UAAZHRBbImKJqKIyEkoHiCATgP54AouDy+QLrcgIMAQQ78FwHU6AHR6PDu5o-VYeT1QBYAQk2KwggaIMwggqtzWaHl8MYT+ED+n8yEQSe1QnT1szUhGwEQvFmeaTheLEErUioEGQfKaVczjf9joUwbqC0bBaLJcDij2bckJma8+rXrrDd9TYnrdcLwGQxGUDGEymMyg4z+-jAUEw5JZ6OY14a2IWI2OwEOMvQcrNSNFel4Et4pLvpgjLCDSohuLaBKQg6XAYESCwHl8MwAFQxhWzSQd6AiIN6tAgB4nZEKhp5-mAT4QIsmQAPS8hoVH+AARthwCBsAeCZHsM7NPhhHEQQZ5kX8XQLNRtG8FR+CpGArHsYwzGce4zQ1iuciKCoABMxgFHsQA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gozala Gozala Awaiting requested review from Gozala

@gobengo gobengo Awaiting requested review from gobengo

@olizilla olizilla Awaiting requested review from olizilla

@alanshaw alanshaw Awaiting requested review from alanshaw

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@travis @Gozala @alanshaw