feat: verify required variables in dataset #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n internal variable list
#Conflicts: # .Rbuildignore # DESCRIPTION
signekb
reviewed
Mar 15, 2024
…/check-variables
…s/osdc into feat/check-variables
Co-authored-by: Signe Kirk Brødbæk <[email protected]>
Aastedet
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a "stacked PR" that builds on #37.
Adds two functions, along with documentation and tests.
verify_required_variables()will be used internally for functions to check that the input dataset contains the correct variables for the algorithm.get_register_abbrev()lists the abbreviations for the registers we require.Also created an internal dataset that lists the registers and variables needed. This internal dataset (generated in
data-raw/variable-descriptions.Rfile) is used for other functions to check that the data has the correct variables.Closes #33