feat: include variable description as exported dataset as well as a function to get the required variables #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/list-needed-vars
signekb
reviewed
Mar 15, 2024
…/list-needed-vars
…s/osdc into feat/list-needed-vars # Conflicts: # tests/testthat/test-verify-variables.R
Co-authored-by: Signe Kirk Brødbæk <[email protected]>
Aastedet
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #16 and is a stacked PR the depends on #45.
I originally had the
required_variablesas an internal dataset, but it makes more sense that more of thevariable-descriptiondata is "exported" (available to the user) so that they can use that if needed. Converting into a "exported" object is done by saving it todata/as a.rdaobject (viausethis::use_data()).I included documentation on that dataset in
R/variable-description.R.I created an
get_helper function to extract the required variables from a given register (along with unit tests for the helper functions).