Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): allow input config and extraArgs #344

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions charts/podinfo/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ The following tables lists the configurable parameters of the podinfo chart and
| `service.nodePort` | `31198` | NodePort for the HTTP endpoint |
| `h2c.enabled` | `false` | Allow upgrading to h2c (non-TLS version of HTTP/2) |
| `extraEnvs` | `[]` | Extra environment variables for the podinfo container |
| `config.path` | `""` | config file path |
| `config.name` | `""` | config file name |
| `extraArgs` | `[]` | Additional command line arguments to pass to podinfo container |
| `hpa.enabled` | `false` | Enables the Kubernetes HPA |
| `hpa.maxReplicas` | `10` | Maximum amount of pods |
| `hpa.cpu` | `None` | Target CPU usage per pod |
Expand Down
9 changes: 9 additions & 0 deletions charts/podinfo/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,15 @@ spec:
{{- if .Values.h2c.enabled }}
- --h2c
{{- end }}
{{- with .Values.config.path }}
- --config-path={{ . }}
{{- end }}
{{- with .Values.config.name }}
- --config={{ . }}
{{- end }}
{{- with .Values.extraArgs }}
{{- toYaml . | nindent 12 }}
{{- end }}
env:
{{- if .Values.ui.message }}
- name: PODINFO_UI_MESSAGE
Expand Down
10 changes: 10 additions & 0 deletions charts/podinfo/values-prod.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,16 @@ service:
h2c:
enabled: false

# config file settings
config:
# config file path
path: ""
# config file name
name: ""

# Additional command line arguments to pass to podinfo container
extraArgs: []

# enable tls on the podinfo service
tls:
enabled: false
Expand Down
10 changes: 10 additions & 0 deletions charts/podinfo/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,16 @@ service:
h2c:
enabled: false

# config file settings
config:
# config file path
path: ""
# config file name
name: ""

# Additional command line arguments to pass to podinfo container
extraArgs: []

# enable tls on the podinfo service
tls:
enabled: false
Expand Down
Loading