Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): allow input config and extraArgs #344

Conversation

toyamagu-2021
Copy link
Contributor

@toyamagu-2021 toyamagu-2021 commented Feb 27, 2024

Signed-off-by: toyamagu2021 [email protected]

Motivation

  • Allow input config and config-path
  • Allow input extraArgs to input arbitral options

Modification

  • add config.name, config.path, and extraArgs to chart

Verification

  • config.name, config.path
config:
  path: "."
  name: "config.yaml"
$ helm template . -s templates/deployment.yaml
          command:
            - ./podinfo
            - --port=9898
            - --cert-path=/data/cert
            - --port-metrics=9797
            - --grpc-port=9999
            - --grpc-service-name=podinfo
            - --level=info
            - --random-delay=false
            - --random-error=false
            - --config-path=.
            - --config=config.yaml
  • extraArgs
extraArgs:
- --test=test
$ helm template . -s templates/deployment.yaml
          command:
            - ./podinfo
            - --port=9898
            - --cert-path=/data/cert
            - --port-metrics=9797
            - --grpc-port=9999
            - --grpc-service-name=podinfo
            - --level=info
            - --random-delay=false
            - --random-error=false
            - --test=test

@toyamagu-2021 toyamagu-2021 force-pushed the feat-allow-input-config-and-extraArgs branch from dda41cf to d0aceab Compare February 27, 2024 15:17
@toyamagu-2021 toyamagu-2021 marked this pull request as ready for review February 27, 2024 15:18
@mhulscher
Copy link
Contributor

I am looking for this functionality as well :) Is there anything preventing this from being merged?

@stefanprodan
Copy link
Owner

@toyamagu-2021 can you rebase with master and resolve the conflicts please

@toyamagu-2021 toyamagu-2021 force-pushed the feat-allow-input-config-and-extraArgs branch from d0aceab to d7c1bf0 Compare March 26, 2024 00:28
@toyamagu-2021
Copy link
Contributor Author

@stefanprodan
thanks! rebased

@stefanprodan stefanprodan merged commit d562a2a into stefanprodan:master Mar 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants