Implement gRPC for echo and version APIs
#322
Conversation
|
@stefanprodan please review this. |
|
@stefanprodan added logger and config to ehco |
| ) | ||
|
|
||
| type echoServer struct { | ||
| echo.UnimplementedEchoServiceServer |
There was a problem hiding this comment.
Why is this call Unimplemented?
There was a problem hiding this comment.
That's something protoc-gen-grpc-go compiler now throws an error for in newer version must be embedded to have forward compatible implementations., it act as a placeholder or a default behavior for any methods that have not yet been implemented in your code
|
@stefanprodan please review |
|
Tests panic here |
|
@stefanprodan can you please review it once again |
|
@stefanprodan please review |
|
@stefanprodan could you please review and let us know? Thanks! |
|
@stefanprodan Could you please review it once, so that we can go ahead with next set APIs, it has been a while now. Thanks. |
|
@stefanprodan please review this; we want to contribute more . |
|
Hey sorry for the delay, I've been busy with work and didn't had time left for podinfo. Can you please rebase with master and force push so the test will run. Thanks for your patience! |
added grpc verion and echo apis --------- Co-authored-by: Prashant Dwivedi <[email protected]>
JayKaku
force-pushed
the
feature/grpc-version-echo-apis
branch
from
4856301
to
2251bee
Compare
Done! Force pushed the branch after a rebase with the master |
stefanprodan
changed the title
echo and version APIs
@stefanprodan here is the restructured api to api/http and api/grpc along with adding functionality of version and echo api