Feature grpc version echo api #321
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Started the GRPC APIs with Version API
Added the test cases for GRPC apis
There was a problem hiding this comment.
@JayKaku I suggest you rewrite the Git history and have a commit for the api/http rename, one for the grpc and another with echo/panic/version.
| server := health.NewServer() | ||
|
|
||
| // Register grpc apis for refection | ||
| echo.RegisterEchoServiceServer(srv, &echoServer{}) |
There was a problem hiding this comment.
The other servers ake a config and logger args, should't this do the same?
| } | ||
|
|
||
| func (s *echoServer) Echo (ctx context.Context, message *echo.Message) (*echo.Message, error){ | ||
| log.Printf("Received message body from client: %s", message.Body) |
There was a problem hiding this comment.
We need to use the server logger instead of default one.
tash
Outdated
| @@ -0,0 +1,13 @@ | |||
| [1mdiff --git a/cmd/podinfo/main.go b/cmd/podinfo/main.go[m | |||
@stefanprodan we are planning to raise another PR because the git history is entangled |
|
Superseded by #322 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#318 @stefanprodan : Added
versionandechogrpc apis and restructured folders and changedpackage apitopackage http