Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runner with v1 <> v2 toggle #1378

Merged
merged 5 commits into from
May 28, 2024
Merged

Runner with v1 <> v2 toggle #1378

merged 5 commits into from
May 28, 2024

Conversation

sourishkrout
Copy link
Member

@sourishkrout sourishkrout commented May 24, 2024

Keep Runner v1 as default but allow v2 To allow for broader testing.

PS: C/I will fail until this PR's protos were published: stateful/runme#589

Copy link
Contributor

@pastuxso pastuxso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running locally, everything works 👌. But please review my comments.

image

src/extension/grpc/client.ts Show resolved Hide resolved
src/extension/grpc/runner/types.ts Outdated Show resolved Hide resolved
src/extension/grpc/runner/types.ts Outdated Show resolved Hide resolved
src/extension/grpc/runner/types.ts Outdated Show resolved Hide resolved
src/extension/grpc/runner/types.ts Outdated Show resolved Hide resolved
src/extension/grpc/runner/types.ts Outdated Show resolved Hide resolved
src/extension/grpc/runner/types.ts Outdated Show resolved Hide resolved
src/extension/grpc/runner/types.ts Outdated Show resolved Hide resolved
src/extension/provider/runmeTask.ts Outdated Show resolved Hide resolved
src/extension/runner/index.ts Show resolved Hide resolved
Copy link

sonarcloud bot commented May 28, 2024

@sourishkrout sourishkrout merged commit 4420562 into main May 28, 2024
4 checks passed
@sourishkrout sourishkrout deleted the seb-runner-migr branch May 28, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants