-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Foyle language id on cells #1389
Conversation
Right now when I try to build this I get an error
I'm guessing this is might be related to #1378 which says the proto changes need to be published. |
Confirmed; I cherry-picked this change onto the 3.5.7 branch and the build succeeded so I don't think the failure is related to my PR. |
I confirmed when I cherry-picked this onto the 3.5.7 it fixed jlewi/foyle#125 |
Just merged that into |
* See jlewi/foyle#125 the language id isn't being set on cells inserted from Foyle * As a result the language gets set to `text` and they aren't runnable.
@sourishkrout I think this PR is ready for review. I rebased on main; I'm still seeing the build error. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
🤔 it worked for me after I ran |
text
and they aren't runnable.