-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pagination support #140
Merged
Merged
Pagination support #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actually use it when writing.
…` to return true here.
jesseleite
force-pushed
the
pagination
branch
2 times, most recently
from
July 13, 2023 01:01
cb4286a
to
5d061cd
Compare
Great! It works perfectly. Thanks a lot!! |
thomaskenne
pushed a commit
to thomaskenne/ssg
that referenced
this pull request
Feb 10, 2024
Co-authored-by: Jason Varga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we linked people to this gist, which was self-described as a temporary workaround:
This PR adds intelligent pagination support by detecting where paginators are used in core (ie. the
{{ collection }}
tag with thepaginate
parameter), generating/articles/page/2
style urls for each page where necessary.No extra setup or user config is required, unless the user wishes to customize the output url, which they can do like so...
'pagination_route' => '{url}/{page_name}/{page_number}'
would result in/articles/page/2
(default)'pagination_route' => '{url}/{page_name}-{page_number}'
would result in/articles/page-2
'pagination_route' => '{url}/{page_name}{page_number}'
would result in/articles/page2
'pagination_route' => '{url}/p/{page_number}'
would result in/articles/p/2
'pagination_route' => '{url}/p{page_number}'
would result in/articles/p2
'pagination_route' => '{url}/{page_number}'
would result in/articles/2
'pagination_route' => '{url}{page_number}'
would result in/articles2
This PR also respects multisite collection indexes, as well as collection tag per-page settings, filters, query scopes, pagination links, auto_links, etc.
Closes #10
Closes #63