Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paginated urls with custom routing (ie. when using SSG) #288

Merged
merged 4 commits into from
Aug 4, 2023

Conversation

jesseleite
Copy link
Member

@jesseleite jesseleite commented Aug 3, 2023

A customer reported via email that when using statamic/seo-pro with statamic/ssg, Seo Pro doesn't output the proper pagination links in the meta (ie. a statically generated site will have custom pagination routing that uses a configurable /articles/page/2 style convention, instead of the typical /articles?page=2 get parameters). This PR uses the blinked paginator to generate SSG-friendly URLs when generating SEO meta for static pages.

References statamic/ssg#140

@jesseleite jesseleite marked this pull request as ready for review August 4, 2023 19:56
@jesseleite jesseleite changed the title Fix paginated urls with custom routing Fix paginated urls with custom routing (ie. when using SSG) Aug 4, 2023
@jesseleite jesseleite merged commit 5e5a06b into master Aug 4, 2023
24 checks passed
@jesseleite jesseleite deleted the fix-paginated-urls-with-custom-routing branch August 4, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant