-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fall back to CPU in small FRI. #840
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
035ae28
to
89d9f9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 5 files at r1, all commit messages.
Reviewable status: 2 of 5 files reviewed, 2 unresolved discussions (waiting on @alonh5 and @shaharsamocha7)
crates/prover/src/core/backend/simd/circle.rs
line 337 at r1 (raw file):
a.swap_with_slice(&mut c[0..n0]); } fold(&poly.coeffs.to_cpu(), &mappings)
Suggestion:
poly.coeffs.as_slice()
crates/prover/src/core/backend/simd/fri.rs
line 59 at r1 (raw file):
} fn fold_circle_into_line(
Tests for these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 5 files reviewed, 2 unresolved discussions (waiting on @andrewmilson and @shaharsamocha7)
crates/prover/src/core/backend/simd/circle.rs
line 337 at r1 (raw file):
a.swap_with_slice(&mut c[0..n0]); } fold(&poly.coeffs.to_cpu(), &mappings)
Done.
crates/prover/src/core/backend/simd/fri.rs
line 59 at r1 (raw file):
Previously, andrewmilson (Andrew Milson) wrote…
Tests for these?
I added tests for a full proof of wide_fib with sizes 3 and 2, do you think that should be enough?
89d9f9b
to
a60c629
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #840 +/- ##
==========================================
+ Coverage 91.99% 92.01% +0.01%
==========================================
Files 90 90
Lines 12188 12204 +16
Branches 12188 12204 +16
==========================================
+ Hits 11212 11229 +17
Misses 869 869
+ Partials 107 106 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1a9755a
to
e601d40
Compare
a60c629
to
dccfd18
Compare
e601d40
to
9119571
Compare
dccfd18
to
e0bfe23
Compare
9119571
to
8455db6
Compare
e0bfe23
to
001b48b
Compare
8455db6
to
37ca835
Compare
001b48b
to
ceb9ebb
Compare
37ca835
to
125f43e
Compare
ceb9ebb
to
2390e49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 6 files reviewed, all discussions resolved (waiting on @shaharsamocha7)
125f43e
to
ec30186
Compare
2390e49
to
cfb13e3
Compare
ec30186
to
a8fff1b
Compare
cfb13e3
to
0aafcdf
Compare
0aafcdf
to
d14ba6b
Compare
This change is