Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to CPU in small constraint eval. #838

Open
wants to merge 1 commit into
base: 09-09-fall_back_to_cpu_in_small_fft_size
Choose a base branch
from

Conversation

alonh5
Copy link
Contributor

@alonh5 alonh5 commented Sep 17, 2024

This change is Reviewable

Copy link
Contributor Author

alonh5 commented Sep 17, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alonh5 and the rest of your teammates on Graphite Graphite

@alonh5 alonh5 force-pushed the 09-09-fall_back_to_cpu_in_small_fft_size branch from cced27f to 77b7cdd Compare September 17, 2024 13:18
@alonh5 alonh5 force-pushed the 09-17-fall_back_to_cpu_in_small_constraint_eval branch 3 times, most recently from 7fe3ce2 to 1a9755a Compare September 18, 2024 08:28
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 86.27451% with 14 lines in your changes missing coverage. Please review.

Project coverage is 92.00%. Comparing base (77b7cdd) to head (125f43e).

Files with missing lines Patch % Lines
...ates/prover/src/constraint_framework/cpu_domain.rs 73.58% 14 Missing ⚠️
Additional details and impacted files
@@                             Coverage Diff                              @@
##           09-09-fall_back_to_cpu_in_small_fft_size     #838      +/-   ##
============================================================================
+ Coverage                                     91.82%   92.00%   +0.17%     
============================================================================
  Files                                            89       90       +1     
  Lines                                         12102    12202     +100     
  Branches                                      12102    12202     +100     
============================================================================
+ Hits                                          11113    11226     +113     
+ Misses                                          882      869      -13     
  Partials                                        107      107              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alonh5 alonh5 force-pushed the 09-17-fall_back_to_cpu_in_small_constraint_eval branch 4 times, most recently from 8455db6 to 37ca835 Compare September 19, 2024 12:54
@alonh5 alonh5 force-pushed the 09-17-fall_back_to_cpu_in_small_constraint_eval branch from 37ca835 to 125f43e Compare September 19, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants