Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bound number properties and make builtin resources optional #164

Merged
merged 2 commits into from
Nov 12, 2023
+46 −26
Merged

Bound number properties and make builtin resources optional #164

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88f71e0
bound number fields by FELT and make builtin resources optional
ArielElp Nov 12, 2023
274656b
add >0 constraint to builtins
ArielElp Nov 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 46 additions & 26 deletions api/starknet_api_openrpc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2376,7 +2376,7 @@
"version": {
"title": "Version",
"description": "Version of the transaction scheme",
"$ref": "#/components/schemas/NUM_AS_HEX"
"$ref": "#/components/schemas/FELT"
},
"type": {
"title": "Deploy",
Expand Down Expand Up @@ -2657,7 +2657,7 @@
"version": {
"title": "Version",
"description": "Version of the transaction scheme",
"$ref": "#/components/schemas/NUM_AS_HEX"
"$ref": "#/components/schemas/FELT"
},
"type": {
"title": "type",
Expand Down Expand Up @@ -3621,17 +3621,17 @@
"gas_consumed": {
"title": "Gas consumed",
"description": "The Ethereum gas cost of the transaction (see https://docs.starknet.io/docs/Fees/fee-mechanism for more info)",
"$ref": "#/components/schemas/NUM_AS_HEX"
"$ref": "#/components/schemas/FELT"
},
"gas_price": {
"title": "Gas price",
"description": "The gas price (in gwei) that was used in the cost estimation",
"$ref": "#/components/schemas/NUM_AS_HEX"
"$ref": "#/components/schemas/FELT"
},
"overall_fee": {
"title": "Overall fee",
"description": "The estimated fee for the transaction (in gwei), product of gas_consumed and gas_price",
"$ref": "#/components/schemas/NUM_AS_HEX"
"$ref": "#/components/schemas/FELT"
}
},
"required": [
Expand Down Expand Up @@ -3698,12 +3698,12 @@
"max_amount": {
"title": "max amount",
"description": "the max amount of the resource that can be used in the tx",
"$ref": "#/components/schemas/NUM_AS_HEX"
"$ref": "#/components/schemas/FELT"
},
"max_price_per_unit": {
"title": "max price",
"description": "the max price per unit of this resource for this tx",
"$ref": "#/components/schemas/NUM_AS_HEX"
"$ref": "#/components/schemas/FELT"
}
},
"required": [
Expand All @@ -3717,12 +3717,12 @@
"price_in_strk": {
"title": "price in strk",
"description": "the price of one unit of the given resource, denominated in strk",
"$ref": "#/components/schemas/NUM_AS_HEX"
"$ref": "#/components/schemas/FELT"
},
"price_in_wei": {
"title": "price in wei",
"description": "the price of one unit of the given resource, denominated in wei",
"$ref": "#/components/schemas/NUM_AS_HEX"
"$ref": "#/components/schemas/FELT"
}
},
"required": [
Expand All @@ -3738,58 +3738,78 @@
"steps": {
"title": "Steps",
"description": "The number of Cairo steps used",
"type": "integer"
"type": "integer",
"not": {
"const": 0
}
},
"memory_holes": {
"title": "Memory holes",
"description": "The number of unused memory cells (each cell is roughly equivalent to a step)",
"type": "integer"
"type": "integer",
"not": {
"const": 0
}
},
"range_check_builtin_applications": {
"title": "Range check applications",
"description": "The number of RANGE_CHECK builtin instances",
"type": "integer"
"type": "integer",
"not": {
"const": 0
}
},
"pedersen_builtin_applications": {
"title": "Pedersen applications",
"description": "The number of Pedersen builtin instances",
"type": "integer"
"type": "integer",
"not": {
"const": 0
}
},
"poseidon_builtin_applications": {
"title": "Poseidon applications",
"description": "The number of Poseidon builtin instances",
"type": "integer"
"type": "integer",
"not": {
"const": 0
}
},
"ec_op_builtin_applications": {
"title": "EC_OP applications",
"description": "the number of EC_OP builtin instances",
"type": "integer"
"type": "integer",
"not": {
"const": 0
}
},
"ecdsa_builtin_applications": {
"title": "ECDSA applications",
"description": "the number of ECDSA builtin instances",
"type": "integer"
"type": "integer",
"not": {
"const": 0
}
},
"bitwise_builtin_applications": {
"title": "BITWISE applications",
"description": "the number of BITWISE builtin instances",
"type": "integer"
"type": "integer",
"not": {
"const": 0
}
},
"keccak_builtin_applications": {
"title": "Keccak applications",
"description": "The number of KECCAK builtin instances",
"type": "integer"
"type": "integer",
"not": {
"const": 0
}
}
},
"required": [
"steps",
"range_check_builtin_applications",
"pedersen_builtin_applications",
"poseidon_builtin_applications",
"ec_op_builtin_applications",
"ecdsa_builtin_applications",
"bitwise_builtin_applications",
"keccak_builtin_applications"
"steps"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't memory_holes be required too?

]
}
},
Expand Down