Bound number properties and make builtin resources optional #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "ecdsa_builtin_applications", | ||
| "bitwise_builtin_applications", | ||
| "keccak_builtin_applications" | ||
| "steps" |
There was a problem hiding this comment.
Shouldn't memory_holes be required too?
ArielElp
commented
Nov 12, 2023
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @yair-starkware)
api/starknet_api_openrpc.json line 3785 at r1 (raw file):
Previously, yair-starkware (Yair) wrote…
Shouldn't memory_holes be required too?
I don't think that you necessarily have them, it should be possible to write a simple program with no memory holes.
yair-starkware
approved these changes
Nov 12, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ArielElp)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is