Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break status into execution status and finality status #107

Merged
merged 1 commit into from
Jul 9, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 34 additions & 16 deletions api/starknet_api_openrpc.json
Original file line number Diff line number Diff line change
Expand Up @@ -2088,9 +2088,13 @@
"$ref": "#/components/schemas/FELT",
"description": "The fee that was charged by the sequencer"
},
"status": {
"title": "Status",
"$ref": "#/components/schemas/TXN_STATUS"
"execution_status": {
"title": "Execution status",
"$ref": "#/components/schemas/TXN_EXECUTION_STATUS"
},
"finality_status": {
"title": "Finality status",
"$ref": "#/components/schemas/TXN_FINALITY_STATUS"
},
"block_hash": {
"title": "Block hash",
Expand All @@ -2107,7 +2111,7 @@
"$ref": "#/components/schemas/MSG_TO_L1"
}
},
"revert_reason":{
"revert_reason": {
"title": "Revert reason",
"name": "revert reason",
"description": "the revert reason for the failed execution",
Expand All @@ -2125,7 +2129,8 @@
"required": [
"transaction_hash",
"actual_fee",
"status",
"finality_status",
"execution_status",
"block_hash",
"block_number",
"messages_sent",
Expand Down Expand Up @@ -2333,28 +2338,33 @@
"$ref": "#/components/schemas/EVENT"
}
},
"revert_reason":{
"revert_reason": {
"title": "Revert reason",
"name": "revert reason",
"description": "the revert reason for the failed execution",
"type": "string"
},
"status":{
"title": "Transaction status",
"finality_status": {
"title": "Finality status",
"type": "string",
"enum": [
"ACCEPTED_ON_L2",
"REVERTED"
"ACCEPTED_ON_L2"
],
"description": "The status of the transaction"
"description": "The finality status of the transaction"
},
Comment on lines +2347 to +2354
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be TXN_FINALITY_STATUS and not its own enum?

"execution_status": {
"title": "Execution status",
"$ref": "#/components/schemas/TXN_EXECUTION_STATUS"
}
},
"required": [
"transaction_hash",
"actual_fee",
"type",
"messages_sent",
"events"
"events",
"finality_status",
"execution_status"
]
},
"PENDING_DEPLOY_TXN_RECEIPT": {
Expand Down Expand Up @@ -2447,15 +2457,23 @@
"payload"
]
},
"TXN_STATUS": {
"title": "Transaction status",
"TXN_FINALITY_STATUS": {
"title": "Finality status",
"type": "string",
"enum": [
"ACCEPTED_ON_L2",
"ACCEPTED_ON_L1",
"ACCEPTED_ON_L1"
],
"description": "The finality status of the transaction"
},
"TXN_EXECUTION_STATUS": {
"title": "Execution status",
"type": "string",
"enum": [
"SUCCEDED",
"REVERTED"
],
"description": "The status of the transaction"
"description": "The execution status of the transaction"
},
"TXN_TYPE": {
"title": "Transaction type",
Expand Down