Break status into execution status and finality status #107
Conversation
| "finality_status": { | ||
| "title": "Finality status", | ||
| "type": "string", | ||
| "enum": [ | ||
| "ACCEPTED_ON_L2", | ||
| "REVERTED" | ||
| "ACCEPTED_ON_L2" | ||
| ], | ||
| "description": "The status of the transaction" | ||
| "description": "The finality status of the transaction" | ||
| }, |
There was a problem hiding this comment.
This should be TXN_FINALITY_STATUS and not its own enum?
There was a problem hiding this comment.
correct, done
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @EvyatarO and @Mirko-von-Leipzig)
api/starknet_api_openrpc.json line 2262 at r1 (raw file):
Previously, Mirko-von-Leipzig (Mirko von Leipzig) wrote…
This should be
TXN_FINALITY_STATUSand not its own enum?
This is PENDING_RECEIPT_... so there’s only one possible option for the finality. So far, this is how we have represented "constant" fields in different objects. WDYT?
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Dismissed @Mirko-von-Leipzig from a discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @EvyatarO)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
|
@yoga-braavos |
This change is