add starknet_estimateMessageFee endpoint #100
Conversation
api/starknet_api_openrpc.json
Outdated
| "name": "message", | ||
| "description": "the message's parameters", | ||
| "schema": { | ||
| "$ref": "#/components/schemas/FUNCTION_CALL" |
There was a problem hiding this comment.
Wouldn't it be more precise if we did not reuse FUNCTION_CALL here? Just similar to how there are separate types for the L1 handler call and the function call in cairo-lang: CallFunction and CallL1Handler
For example reusing calldata in FUNCTION_CALL for storing the payload of the L1 message sounds a bit like a hack to me...
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @kkovaacs)
api/starknet_api_openrpc.json line 548 at r1 (raw file):
Previously, kkovaacs (KOVACS Krisztian) wrote…
Wouldn't it be more precise if we did not reuse FUNCTION_CALL here? Just similar to how there are separate types for the L1 handler call and the function call in cairo-lang: CallFunction and CallL1Handler
For example reusing
calldatain FUNCTION_CALL for storing thepayloadof the L1 message sounds a bit like a hack to me...
added a MSG_FROM_L1 type to distinguish this from function call and not use calldata
api/starknet_api_openrpc.json
Outdated
| "required": true | ||
| }, | ||
| { | ||
| "name": "sender_address", |
There was a problem hiding this comment.
Isn't sender_address redundant now that from_address is part of MSG_FROM_L1?
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @kkovaacs)
api/starknet_api_openrpc.json line 553 at r2 (raw file):
Previously, kkovaacs (KOVACS Krisztian) wrote…
Isn't
sender_addressredundant now thatfrom_addressis part ofMSG_FROM_L1?
Correct, fixed
There was a problem hiding this comment.
LGTM
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ArielElp)
This change is