[ADD] Implement starknet_estimateMessageFee method #84
Conversation
dioKaratzas
changed the title
| @@ -56,6 +56,18 @@ struct EstimateFeeParams: Encodable { | |||
| } | |||
| } | |||
|
|
|||
| struct EstimateMessageFeeParams: Encodable { | |||
| let message: StarknetCall | |||
There was a problem hiding this comment.
I think it should be MSG_FROM_L1 struct instead:
"MSG_FROM_L1": {
"title": "Message from L1",
"type": "object",
"properties": {
"from_address": {
"description": "The address of the L1 contract sending the message",
"$ref": "#/components/schemas/ETH_ADDRESS"
},
"to_address": {
"title": "To address",
"description": "The target L2 address the message is sent to",
"$ref": "#/components/schemas/ADDRESS"
},
"payload": {
"description": "The payload of the message",
"title": "Payload",
"type": "array",
"items": {
"$ref": "#/components/schemas/FELT"
}
}
},
There was a problem hiding this comment.
@bartekryba We need to clarify as I tried that already and was getting the following error by using our provider:
AccountTest.swift:174: error: -[StarknetTests.AccountTests testEtimateMessageFee] : failed: caught error: "jsonRpcError(-32602, "missing field `contract_address` at line 1 column 258")"
Test Case '-[StarknetTests.AccountTests testEtimateMessageFee]' failed (2.424 seconds).
Please check starkware-libs/starknet-specs@37c5ed1
It is tagged for v0.4.0-rc1.
The contract_address relates to the v0.4.0-rc1. Should we wait to tag a new release with the MSG_FROM_L1 struct change included?
There was a problem hiding this comment.
I checked the commit, but it was actually a part of a PR, where it was changed to MSG_FROM_L1 starkware-libs/starknet-specs#100
There was a problem hiding this comment.
Ok we can change, as that change will reflect to the next release
There was a problem hiding this comment.
@bartekryba Fixed 6f9a005
dioKaratzas
force-pushed
the
feat/estimate-message
branch
from
6f9a005
to
22785ab
Compare
|
Reverted back to 22785ab |
Resolves #80