Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(base_layer): add safe conversion to felt #856

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

giladchase
Copy link
Contributor

@giladchase giladchase commented Sep 18, 2024

commit-id:a4bb6349


Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.


This change is Reviewable

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.31%. Comparing base (7da2d63) to head (62d84d3).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...rus_base_layer/src/ethereum_base_layer_contract.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #856      +/-   ##
==========================================
+ Coverage   74.29%   74.31%   +0.01%     
==========================================
  Files         358      358              
  Lines       36288    36226      -62     
  Branches    36288    36226      -62     
==========================================
- Hits        26960    26921      -39     
+ Misses       7190     7167      -23     
  Partials     2138     2138              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @giladchase)


crates/papyrus_base_layer/src/ethereum_base_layer_contract.rs line 36 at r1 (raw file):

    #[error(transparent)]
    FeltParseError(#[from] felt::FromStrError),
}

Keep alphabetized?

Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @giladchase)

Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @giladchase)

@giladchase giladchase changed the base branch from spr/main/0a043060 to main September 19, 2024 13:11
Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)

@giladchase giladchase merged commit 633f8fd into main Sep 19, 2024
24 of 44 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants