Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(base_layer): add types to config #855

Merged
merged 1 commit into from
Sep 19, 2024
Merged

feat(base_layer): add types to config #855

merged 1 commit into from
Sep 19, 2024

Conversation

giladchase
Copy link
Contributor

@giladchase giladchase commented Sep 18, 2024 •
edited by alon-dotan-starkware
Loading

  • implement the TODO for adding types to the Config, rather than working
    with raw strings.
  • using Url for url and re-exporting alloy's Address type in order
    to not externalize this implementation detail type unnecessarily.
  • Remove 2 errors that are now no longer the responsibility of this
    module, the callsite will have to handle the casting into the correct
    types.

commit-id:0a043060

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This change is Reviewable

This was referenced Sep 18, 2024
Merged
Merged
@github-actions GitHub Actions
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [67.242 ms 67.318 ms 67.402 ms]
change: [-7.6901% -4.3080% -1.4321%] (p = 0.00 < 0.05)
Performance has improved.
Found 9 outliers among 100 measurements (9.00%)
1 (1.00%) low mild
5 (5.00%) high mild
3 (3.00%) high severe

@giladchase giladchase mentioned this pull request Sep 18, 2024
Merged
@github-actions GitHub Actions
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [67.007 ms 67.106 ms 67.235 ms]
change: [-9.1198% -5.7892% -2.8347%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
1 (1.00%) high mild
3 (3.00%) high severe

@github-actions GitHub Actions
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.124 ms 66.239 ms 66.377 ms]
change: [-7.7785% -4.6125% -1.8717%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
4 (4.00%) high mild
1 (1.00%) high severe

@codecov Codecov
Copy link

codecov bot commented Sep 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.29%. Comparing base (1ad069a) to head (5637076).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #855   +/-   ##
=======================================
  Coverage   74.29%   74.29%           
=======================================
  Files         358      358           
  Lines       36280    36288    +8     
  Branches    36280    36288    +8     
=======================================
+ Hits        26953    26961    +8     
- Misses       7188     7190    +2     
+ Partials     2139     2137    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

elintul
elintul approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)

@github-actions GitHub Actions
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.576 ms 66.726 ms 66.897 ms]
change: [-7.7883% -4.3141% -1.4040%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
1 (1.00%) high mild
3 (3.00%) high severe

@giladchase giladchase mentioned this pull request Sep 18, 2024
Merged
elintul
elintul approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)

@giladchase giladchase changed the base branch from spr/main/19ed8b4a to main September 19, 2024 08:36
@github-actions GitHub Actions
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.667 ms 66.166 ms 66.870 ms]
change: [-7.9950% -4.4419% -1.3797%] (p = 0.01 < 0.05)
Performance has improved.
Found 9 outliers among 100 measurements (9.00%)
3 (3.00%) high mild
6 (6.00%) high severe

elintul
elintul approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)

elintul
elintul approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)

feat(base_layer): add types to config
5637076 
- implement the TODO for adding types to the Config, rather than working
  with raw strings.
- using `Url` for url and **re-exporting** `alloy`'s `Address` type in order
  to not externalize this implementation detail type unnecessarily.
- Remove 2 errors that are now no longer the responsibility of this
  module, the callsite will have to handle the casting into the correct
  types.

commit-id:0a043060
@github-actions GitHub Actions
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.226 ms 66.396 ms 66.585 ms]
change: [-8.7342% -5.2757% -2.2992%] (p = 0.00 < 0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
5 (5.00%) high mild
3 (3.00%) high severe

elintul
elintul approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)

@giladchase giladchase merged commit 4bbbc5d into main Sep 19, 2024
29 of 44 checks passed
@github-actions GitHub Actions
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.836 ms 65.925 ms 66.026 ms]
change: [-8.8219% -5.5119% -2.6156%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
5 (5.00%) high mild
2 (2.00%) high severe

@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elintul elintul elintul approved these changes

@dan-starkware dan-starkware Awaiting requested review from dan-starkware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giladchase @elintul