test(blockifier): revert storgae changes

[AvivYossef-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[AvivYossef-starkware]

• refactor(blockifier): revert contract test #2941
• test(blockifier): revert storgae changes #2913 👈 (View in Graphite)
• test(blockifier): inner revert in cairo 1 contract #2889
• test(blockifier): storage changes after inner revert #2918
• main-v0.13.4

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2024-12-24T09:25:19Z
• Started at 2024-12-24T10:24:06Z
• Started at 2024-12-24T10:47:29Z
• Started at 2024-12-24T10:49:52Z
• Started at 2024-12-24T11:44:45Z
• Started at 2024-12-24T12:21:56Z
• Started at 2024-12-24T12:56:44Z
• Started at 2024-12-24T12:57:02Z
• Started at 2024-12-24T12:57:35Z
• Started at 2024-12-24T14:31:57Z
• Started at 2024-12-25T08:31:22Z

[dorimedini-starkware]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @Yoni-Starkware)

---

crates/blockifier/src/execution/syscalls/syscall_tests/call_contract.rs line 213 at r1 (raw file):

    for call in outer_call.iter() {
        assert_eq!(call.tracked_resource, TrackedResource::SierraGas);
    }

what is this for...?
also, just because sierra gas is tracked, doesn't mean native is running

Code quote:

    // Check that the tracked resource is SierraGas to make sure that Native is running.
    for call in outer_call.iter() {
        assert_eq!(call.tracked_resource, TrackedResource::SierraGas);
    }

[Yoni-Starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

crates/blockifier/src/execution/syscalls/syscall_tests/call_contract.rs line 213 at r1 (raw file):

Previously, dorimedini-starkware wrote…

what is this for...?
also, just because sierra gas is tracked, doesn't mean native is running

Yeah that's my code. Currently Native is transparent, but it should run (given the test case) only when all calls are of SierraGas mode.

That's the best we can do right now. We should probably add some flag somewhere, for sanity. Out of scope.

[dorimedini-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

[dorimedini-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

[dorimedini-starkware]

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)

---

a discussion (no related file):
blocking until I'm sure the base branch is correct

[dorimedini-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

[dorimedini-starkware]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

[Yoni-Starkware]

Reviewed 1 of 4 files at r1, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @AvivYossef-starkware)

---

crates/blockifier/feature_contracts/cairo1/test_contract.cairo line 119 at r3 (raw file):

    /// The function performs the following:
    /// 1. Calls `write_10_to_my_storage_var` to set the storage variable to 10.
    /// 2. Calls `test_revert_helper` with `to_panic` = true`.

Suggestion:

`to_panic=true`.

---

crates/blockifier/feature_contracts/cairo1/test_contract.cairo line 121 at r3 (raw file):

    /// 2. Calls `test_revert_helper` with `to_panic` = true`.
    ///    - `test_revert_helper` is expected to change the storage variable to 17 and then panic.
    /// 3. Verifies that the `test_revert_helper`` changes are reverted,

Suggestion:

// 3. Verifies that the `test_revert_helper` changes are reverted,

---

crates/blockifier/feature_contracts/cairo1/test_contract.cairo line 127 at r3 (raw file):

        ref self: ContractState,
        contract_address: ContractAddress,
        class_hash: ClassHash,

Please rename other relevant functions to make it clear

Suggestion:

replacement_class_hash

---

crates/blockifier/src/execution/syscalls/syscall_tests/call_contract.rs line 174 at r3 (raw file):

    let mut state = test_state(chain_info, BALANCE, &[(test_contract, 1), (empty_contract, 0)]);

    // Call data of contract A

Suggestion:

    // Calldata of contract A.

---

crates/blockifier/src/execution/syscalls/syscall_tests/call_contract.rs line 179 at r3 (raw file):

            FeatureContract::TestContract(CairoVersion::Cairo1(RunnableCairo1::Casm))
                .get_instance_address(0)
                .into(),

Please fix other places

Suggestion:

            test_contract.get_instance_address(0).into(),

[AvivYossef-starkware]

Reviewable status: 1 of 4 files reviewed, 5 unresolved discussions (waiting on @dorimedini-starkware and @Yoni-Starkware)

---

crates/blockifier/feature_contracts/cairo1/test_contract.cairo line 127 at r3 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Please rename other relevant functions to make it clear

Done.

---

crates/blockifier/src/execution/syscalls/syscall_tests/call_contract.rs line 179 at r3 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Please fix other places

in different PR

---

crates/blockifier/src/execution/syscalls/syscall_tests/call_contract.rs line 174 at r3 (raw file):

    let mut state = test_state(chain_info, BALANCE, &[(test_contract, 1), (empty_contract, 0)]);

    // Call data of contract A

Done.

---

crates/blockifier/feature_contracts/cairo1/test_contract.cairo line 119 at r3 (raw file):

    /// The function performs the following:
    /// 1. Calls `write_10_to_my_storage_var` to set the storage variable to 10.
    /// 2. Calls `test_revert_helper` with `to_panic` = true`.

Done.

---

crates/blockifier/feature_contracts/cairo1/test_contract.cairo line 121 at r3 (raw file):

    /// 2. Calls `test_revert_helper` with `to_panic` = true`.
    ///    - `test_revert_helper` is expected to change the storage variable to 17 and then panic.
    /// 3. Verifies that the `test_revert_helper`` changes are reverted,

Done.

[Yoni-Starkware]

Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

[dorimedini-starkware]

Reviewed 1 of 3 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)