test(blockifier): storage changes after inner revert #2910
Closed
+7,271
−7,113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Artifacts upload workflows: |
dorimedini-starkware
approved these changes
Dec 24, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)
AvivYossef-starkware
force-pushed
the
aviv/test_storage_changes_after_inner_revert
branch
from
be4a681 to
29e52d0
Compare
AvivYossef-starkware
force-pushed
the
aviv/test_storage_changes_after_inner_revert
branch
from
29e52d0 to
4c44815
Compare
AvivYossef-starkware
force-pushed
the
aviv/test_storage_changes_after_inner_revert
branch
from
4c44815 to
3a6c12f
Compare
AvivYossef-starkware
changed the base branch from
main-v0.13.2
to
main-v0.13.4
AvivYossef-starkware
force-pushed
the
aviv/test_storage_changes_after_inner_revert
branch
from
3a6c12f to
7237414
Compare
dorimedini-starkware
requested changes
Dec 24, 2024
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)
a discussion (no related file):
rebase over main-v0.13.4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.