chore(blockifier): remove fee_transfer_gas_cost #2858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Artifacts upload workflows: |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
meship-starkware
approved these changes
Dec 22, 2024
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noaov1)
Yonatan-Starkware
force-pushed
the
yonatank/blockifier/impl_deserialize_for_versioned_constants
branch
from
389ca2b to
4912cfd
Compare
Yonatan-Starkware
force-pushed
the
yonatank/blockifier/remove_fee_transfer_gas_cost
branch
from
3c6c184 to
cbd78b0
Compare
noaov1
approved these changes
Dec 22, 2024
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:
Yonatan-Starkware
force-pushed
the
yonatank/blockifier/impl_deserialize_for_versioned_constants
branch
2 times, most recently
from
87a65a1 to
8e3dacd
Compare
Yonatan-Starkware
force-pushed
the
yonatank/blockifier/remove_fee_transfer_gas_cost
branch
from
cbd78b0 to
387ef7c
Compare
Yonatan-Starkware
force-pushed
the
yonatank/blockifier/impl_deserialize_for_versioned_constants
branch
from
8e3dacd to
0c59b84
Compare
Yonatan-Starkware
force-pushed
the
yonatank/blockifier/remove_fee_transfer_gas_cost
branch
from
387ef7c to
5ae0664
Compare
meship-starkware
merged commit dfa3538
into
yonatank/blockifier/impl_deserialize_for_versioned_constants
11 checks passed
meship-starkware
deleted the
yonatank/blockifier/remove_fee_transfer_gas_cost
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.