chore(blockifier): impl deserialize for versioned_constants

[Yonatan-Starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2024-12-19T15:15:22Z
• Started at 2024-12-19T15:41:05Z
• Started at 2024-12-19T15:54:16Z
• Started at 2024-12-19T16:15:44Z
• Started at 2024-12-22T07:57:09Z
• Started at 2024-12-22T13:39:52Z
• Started at 2024-12-22T14:06:16Z
• Started at 2024-12-22T14:07:53Z
• Started at 2024-12-22T16:05:16Z
• Started at 2024-12-24T08:34:28Z
• Started at 2024-12-26T08:38:29Z

[Yonatan-Starkware]

• chore(blockifier): remove syscall_gas_costs from os_constans #2864
• chore(blockifier): remove fee_transfer_gas_cost #2858
• chore(blockifier): impl deserialize for versioned_constants #2838 👈 (View in Graphite)
• chore(blockifier): split builtin gas costs from base gas costs #2514 : 1 other dependent PR (#2818 )
• chore(blockifier): add syscalls_gas_costs struct #2359 : 1 other dependent PR (#2501 )
• chore(blockifier): add keccak_builtin_gas_cost #2327
• chore(blockifier): replace entry_point_gas_cost with initial_budget #2247
• feat(blockifier): add get_syscall_gas_cost to versioned constants impl #2188
• feat(blockifier): add impl for GasCosts in versioned_constants #2067
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[meship-starkware]

Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @noaov1 and @Yonatan-Starkware)

---

crates/blockifier/src/versioned_constants.rs line 458 at r2 (raw file):

                    .get_syscall_gas_cost(&SyscallSelector::Secp256r1New),
                keccak: versioned_constants.get_syscall_gas_cost(&SyscallSelector::Keccak),
                keccak_round_cost: 180000,

Is the keccak fix in the next PR? I think it should be before this PR or in this PR.

Code quote:

                keccak: versioned_constants.get_syscall_gas_cost(&SyscallSelector::Keccak),
                keccak_round_cost: 180000,

[meship-starkware]

Reviewed 1 of 1 files at r2.
Reviewable status: 1 of 7 files reviewed, 1 unresolved discussion (waiting on @noaov1 and @Yonatan-Starkware)

[Yonatan-Starkware]

crates/blockifier/src/versioned_constants.rs line 458 at r2 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

Is the keccak fix in the next PR? I think it should be before this PR or in this PR.

In the next PR. It is not really matter as long as the os_constants are still in the json.

[meship-starkware]

Reviewed 6 of 7 files at r4, 6 of 6 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

[noaov1]

Reviewed 6 of 6 files at r3, 1 of 7 files at r4, 6 of 6 files at r5, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Yonatan-Starkware)

---

crates/blockifier/resources/versioned_constants_0_13_0.json line 106 at r5 (raw file):

            "entry_point_initial_budget": 1,
            "step_gas_cost": 600
        },

Next time- better to do it in a separate PR :)

Code quote:

        "fee_transfer_gas_cost": {
            "entry_point_initial_budget": 1,
            "step_gas_cost": 600
        },

---

crates/blockifier/src/versioned_constants.rs line 416 at r5 (raw file):

        let syscall_gas_costs = &(versioned_constants.os_constants.gas_costs.syscalls);
        if syscall_gas_costs == &SyscallGasCosts::default() {

What does ensure that we have a default value when the field is missing?
What will happen here?

Code quote:

        if syscall_gas_costs == &SyscallGasCosts::default() {

---

crates/blockifier/src/versioned_constants.rs line 459 at r5 (raw file):

                    .get_syscall_gas_cost(&SyscallSelector::Secp256r1New),
                keccak: versioned_constants.get_syscall_gas_cost(&SyscallSelector::Keccak),
                keccak_round_cost: 180000,

What does 180000 represent?

Suggestion:

                //TODO(Yonatan): Remove the default value.
                keccak_round_cost: 180000,

[Yonatan-Starkware]

crates/blockifier/resources/versioned_constants_0_13_0.json line 106 at r5 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Next time- better to do it in a separate PR :)

It was. Meshi merged it into this one.

[noaov1]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Yonatan-Starkware)

---

crates/blockifier/src/versioned_constants.rs line 416 at r5 (raw file):

Previously, noaov1 (Noa Oved) wrote…

What does ensure that we have a default value when the field is missing?
What will happen here?

I just saw the added code. Great!

[Yonatan-Starkware]

crates/blockifier/src/versioned_constants.rs line 459 at r5 (raw file):

Previously, noaov1 (Noa Oved) wrote…

What does 180000 represent?

It is the only object in the syscall_gas_costs that does not have a parallel in the os_resources. So I just give it the appropriate value.
In the next PR we add KeccakRound in the OsResources, and then I change this line as well to be as the others.