feat(starknet_state_sync): implement state sync get compiled class

[noamsp-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[noamsp-starkware]

• feat(starknet_state_sync): implement state sync get compiled class #2817 👈 (View in Graphite)
• feat(starknet_state_sync): implement sync state reader get class hash at #2819
• feat(starknet_state_sync): implement sync state reader get nonce at #2757
• feat(starknet_state_sync): implement sync state reader get storage at #2755
• chore(starknet_gateway): create sync state reader infra with todos #2754
• feat(starknet_state_sync): use real state sync client in sequencer consensus manager #2662
• feat(starknet_state_sync): create and run state sync servers #2537 : 1 other dependent PR (#2538 )
• feat(starknet_state_sync): create state sync components #2531
• refactor(starknet_state_sync): refactor state sync to use p2p sync #2515
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ShahakShama]

Reviewed 2 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @noamsp-starkware)

---

crates/starknet_state_sync/src/lib.rs line 155 at r2 (raw file):

    ) -> StateSyncResult<(ContractClass, SierraVersion)> {
        let txn = self.storage_reader.begin_ro_txn()?;
        verify_synced_up_to(&txn, block_number)?;

The check here should be against the casm marker and not the state marker

---

crates/starknet_state_sync/src/lib.rs line 170 at r2 (raw file):

            let (casm, sierra) = option_casm
                .zip(option_sierra)
                .ok_or(StateSyncError::ClassHashNotFound(class_hash))?;

Add a comment that we've checked that block number is smaller than casm marker so if it's missing it's because it doesn't exist

---

crates/starknet_state_sync_types/src/communication.rs line 60 at r2 (raw file):

    ) -> StateSyncClientResult<ClassHash>;

    async fn get_compiled_class(

Add TODO to remove this and use compiler component client instead in SyncStateReader

---

crates/starknet_state_sync_types/src/communication.rs line 60 at r2 (raw file):

    ) -> StateSyncClientResult<ClassHash>;

    async fn get_compiled_class(

rename to get_compiled_class_deprecated so people will fear using it

---

crates/starknet_state_sync_types/src/errors.rs line 17 at r2 (raw file):

    ContractNotFound(ContractAddress),
    #[error("Class hash {0} was not found")]
    ClassHashNotFound(ClassHash),

Rename to ClassNotFound

[noamsp-starkware]

Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @ShahakShama)

---

crates/starknet_state_sync/src/lib.rs line 155 at r2 (raw file):

Previously, ShahakShama wrote…

The check here should be against the casm marker and not the state marker

Ack.
The current rpc state reader checks the state marker and not the casm marker.

---

crates/starknet_state_sync/src/lib.rs line 170 at r2 (raw file):

Previously, ShahakShama wrote…

Add a comment that we've checked that block number is smaller than casm marker so if it's missing it's because it doesn't exist

Done.

---

crates/starknet_state_sync_types/src/communication.rs line 60 at r2 (raw file):

Previously, ShahakShama wrote…

rename to get_compiled_class_deprecated so people will fear using it

Done.

---

crates/starknet_state_sync_types/src/communication.rs line 60 at r2 (raw file):

Previously, ShahakShama wrote…

Add TODO to remove this and use compiler component client instead in SyncStateReader

Done.

---

crates/starknet_state_sync_types/src/errors.rs line 17 at r2 (raw file):

Previously, ShahakShama wrote…

Rename to ClassNotFound

Done.

[ShahakShama]

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware)

---

crates/starknet_state_sync/src/lib.rs line 155 at r2 (raw file):

Previously, noamsp-starkware wrote…

Ack.
The current rpc state reader checks the state marker and not the casm marker.

Yes. They have a bit different case than our case

[noamsp-starkware]

Merge activity

• Dec 22, 3:18 AM EST: A user started a stack merge that includes this pull request via Graphite.
• Dec 22, 3:20 AM EST: Graphite couldn't merge this pull request because a downstack PR feat(starknet_state_sync): implement sync state reader get storage at #2755 failed to merge.

[ShahakShama]

Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware)