chore(starknet_gateway): create sync state reader infra with todos #2754
Conversation
|
This change is |
noamsp-starkware
force-pushed
the
noam.s/sync_state_reader_infra
branch
from
007c21e to
0f4bcbd
Compare
noamsp-starkware
changed the title
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @noamsp-starkware)
a discussion (no related file):
@alonh5 should review this as well. Please send it to him in slack
crates/starknet_state_sync_types/src/communication.rs line 37 at r1 (raw file):
) -> StateSyncClientResult<()>; // TODO: add get_storage_at for BlockifierStateReader trait
This sounds like you want to add this method to the BlockifierStateReader trait. Rephrase it "for SyncStateReader"
crates/starknet_gateway/src/sync_state_reader.rs line 14 at r1 (raw file):
struct SyncStateReader { block_number: BlockNumber, shared_state_sync_client: SharedStateSyncClient,
You can name this state_sync_client
crates/starknet_gateway/src/sync_state_reader.rs line 19 at r1 (raw file):
impl SyncStateReader { pub fn from_number( shared_state_sync_client: &SharedStateSyncClient,
In rust we usually don't take by reference what we then clone, we consume it. This allows the caller to maybe pass to us an object that they don't need anymore and save the clone
@alonh5 FYI since it is copied from the RpcStateReader
noamsp-starkware
force-pushed
the
noam.s/sync_state_reader_infra
branch
from
0f4bcbd to
e00bff3
Compare
noamsp-starkware
changed the base branch from
noam.s/remove_empty_state_sync_client
to
main
|
Artifacts upload workflows: |
|
Benchmark movements: |
There was a problem hiding this comment.
Reviewable status: 2 of 5 files reviewed, 4 unresolved discussions (waiting on @alonh5 and @ShahakShama)
crates/starknet_gateway/src/sync_state_reader.rs line 14 at r1 (raw file):
Previously, ShahakShama wrote…
You can name this state_sync_client
Done.
crates/starknet_gateway/src/sync_state_reader.rs line 19 at r1 (raw file):
Previously, ShahakShama wrote…
In rust we usually don't take by reference what we then clone, we consume it. This allows the caller to maybe pass to us an object that they don't need anymore and save the clone
@alonh5 FYI since it is copied from the RpcStateReader
Done.
crates/starknet_state_sync_types/src/communication.rs line 37 at r1 (raw file):
Previously, ShahakShama wrote…
This sounds like you want to add this method to the BlockifierStateReader trait. Rephrase it "for SyncStateReader"
Done.
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5 and @noamsp-starkware)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5)
a discussion (no related file):
Previously, ShahakShama wrote…
@alonh5 should review this as well. Please send it to him in slack
I spoke with @alonh5; his team's review will be required for the PRs that actually integrate the sync state reader into gateway. resolving this.
No description provided.