Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blockifier): remove versioned runnable contract class #2811

Merged

Conversation

AvivYossef-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/use_sierra_version_in_native_blockifier branch from 1c1fd9d to 09c392b Compare December 19, 2024 10:17
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/remove_versioned_runnable_contract_class branch from 2f09c95 to bbb52f6 Compare December 19, 2024 10:17
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/use_sierra_version_in_native_blockifier branch from 09c392b to 2553415 Compare December 19, 2024 11:39
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/remove_versioned_runnable_contract_class branch from bbb52f6 to 5ab5c77 Compare December 19, 2024 11:40
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/use_sierra_version_in_native_blockifier branch from 2553415 to 46b65f0 Compare December 19, 2024 13:22
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/remove_versioned_runnable_contract_class branch from 5ab5c77 to dbd8230 Compare December 19, 2024 13:22
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/use_sierra_version_in_native_blockifier branch from 46b65f0 to facff36 Compare December 19, 2024 13:49
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/remove_versioned_runnable_contract_class branch from dbd8230 to 574b543 Compare December 19, 2024 13:49
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/use_sierra_version_in_native_blockifier branch from facff36 to 850718f Compare December 19, 2024 16:06
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/remove_versioned_runnable_contract_class branch from 574b543 to 4bdf09e Compare December 19, 2024 16:07
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/use_sierra_version_in_native_blockifier branch 2 times, most recently from 1aff2fe to 48c5672 Compare December 22, 2024 07:38
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/remove_versioned_runnable_contract_class branch 3 times, most recently from 4c82a1f to 2e9162c Compare December 22, 2024 08:08
@AvivYossef-starkware AvivYossef-starkware marked this pull request as ready for review December 22, 2024 08:11
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

@AvivYossef-starkware AvivYossef-starkware changed the base branch from aviv/use_sierra_version_in_native_blockifier to graphite-base/2811 December 22, 2024 09:10
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/remove_versioned_runnable_contract_class branch from 2e9162c to 9fcb757 Compare December 22, 2024 09:10
@AvivYossef-starkware AvivYossef-starkware changed the base branch from graphite-base/2811 to main December 22, 2024 09:11
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/remove_versioned_runnable_contract_class branch from 9fcb757 to f66177d Compare December 22, 2024 09:11
@AvivYossef-starkware AvivYossef-starkware merged commit b1db2e9 into main Dec 22, 2024
18 checks passed
Copy link
Contributor Author

Merge activity

  • Dec 22, 4:32 AM EST: A user merged this pull request with Graphite.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants