Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blockifier): min compiler version for sierra gas type #2752

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

AvivYossef-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/get_versioned_contract_class_in_papyrus_execution branch from 01f3e55 to f34812f Compare December 18, 2024 13:52
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_blockifier_contract_class branch from 1683c47 to 4758e0e Compare December 18, 2024 13:52
@AvivYossef-starkware AvivYossef-starkware marked this pull request as ready for review December 18, 2024 13:59
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/get_versioned_contract_class_in_papyrus_execution branch from f34812f to 26d288a Compare December 18, 2024 14:03
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_blockifier_contract_class branch from 4758e0e to 5e89fc0 Compare December 18, 2024 14:03
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 27 of 27 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @noaov1, and @TzahiTaub)


crates/blockifier/src/execution/contract_class.rs line 312 at r1 (raw file):

    pub fn try_from_json_string(raw_contract_class: &str) -> Result<CompiledClassV1, ProgramError> {
        let casm_contract_class: CasmContractClass = serde_json::from_str(raw_contract_class)?;
        let sierra_version = SierraVersion::default();

is this ok...? where is try_from_json_string used?

Code quote:

let sierra_version = SierraVersion::default();

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/get_versioned_contract_class_in_papyrus_execution branch from 26d288a to dbcfb50 Compare December 18, 2024 14:57
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_blockifier_contract_class branch from 5e89fc0 to 694bb8f Compare December 18, 2024 14:58
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [33.852 ms 33.890 ms 33.931 ms]
change: [-5.0047% -3.5249% -2.2314%] (p = 0.00 < 0.05)
Performance has improved.
Found 12 outliers among 100 measurements (12.00%)
3 (3.00%) low severe
1 (1.00%) low mild
4 (4.00%) high mild
4 (4.00%) high severe

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @noaov1, and @TzahiTaub)

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/get_versioned_contract_class_in_papyrus_execution branch from dbcfb50 to 90b2b84 Compare December 19, 2024 09:01
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_blockifier_contract_class branch from 694bb8f to a040553 Compare December 19, 2024 09:01
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [33.898 ms 34.015 ms 34.196 ms]
change: [-5.0240% -3.3278% -1.8262%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
7 (7.00%) high severe

Copy link
Contributor Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 22 of 28 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware, @noaov1, and @TzahiTaub)


crates/blockifier/src/execution/contract_class.rs line 312 at r1 (raw file):

Previously, dorimedini-starkware wrote…

is this ok...? where is try_from_json_string used?

No, it's not okay. It is used here Here. I'll open another PR for it, and in the meantime, I'll use SierraVersion::deprecated to avoid activating the feature on the Python gateway.

Copy link
Contributor Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add python PR

Reviewable status: 22 of 28 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware, @noaov1, and @TzahiTaub)

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noaov1 and @TzahiTaub)

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/get_versioned_contract_class_in_papyrus_execution branch from 90b2b84 to a9e3e0b Compare December 19, 2024 10:16
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_blockifier_contract_class branch from a040553 to 87285bf Compare December 19, 2024 10:17
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noaov1 and @TzahiTaub)

@AvivYossef-starkware AvivYossef-starkware changed the base branch from aviv/get_versioned_contract_class_in_papyrus_execution to graphite-base/2752 December 19, 2024 11:38
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_blockifier_contract_class branch from 87285bf to 4022be4 Compare December 19, 2024 11:38
@AvivYossef-starkware AvivYossef-starkware changed the base branch from graphite-base/2752 to main December 19, 2024 11:39
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_blockifier_contract_class branch from 4022be4 to 0b19960 Compare December 19, 2024 11:39
Copy link

Benchmark movements:
full_committer_flow performance improved 😺
full_committer_flow time: [29.649 ms 29.691 ms 29.737 ms]
change: [-1.9807% -1.6431% -1.3511%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
4 (4.00%) high mild

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_blockifier_contract_class branch from 0b19960 to 5d8e938 Compare December 19, 2024 13:21
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noaov1 and @TzahiTaub)

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_blockifier_contract_class branch from 5d8e938 to e6dbb02 Compare December 19, 2024 13:49
@AvivYossef-starkware AvivYossef-starkware changed the base branch from main to aviv/add_sierra_version_util December 19, 2024 13:49
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noaov1 and @TzahiTaub)

Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.370 ms 34.423 ms 34.482 ms]
change: [-4.9094% -3.3945% -2.0928%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
3 (3.00%) high mild
1 (1.00%) high severe

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noaov1 and @TzahiTaub)

@AvivYossef-starkware AvivYossef-starkware changed the base branch from aviv/add_sierra_version_util to graphite-base/2752 December 19, 2024 16:06
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_blockifier_contract_class branch from e6dbb02 to 3b35f20 Compare December 19, 2024 16:06
@AvivYossef-starkware AvivYossef-starkware changed the base branch from graphite-base/2752 to main December 19, 2024 16:06
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_blockifier_contract_class branch from 3b35f20 to f88449c Compare December 19, 2024 16:06
@AvivYossef-starkware AvivYossef-starkware merged commit 14fb92b into main Dec 22, 2024
21 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants