-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(blockifier): min compiler version for sierra gas type #2752
refactor(blockifier): min compiler version for sierra gas type #2752
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
01f3e55
to
f34812f
Compare
1683c47
to
4758e0e
Compare
f34812f
to
26d288a
Compare
4758e0e
to
5e89fc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 27 of 27 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @noaov1, and @TzahiTaub)
crates/blockifier/src/execution/contract_class.rs
line 312 at r1 (raw file):
pub fn try_from_json_string(raw_contract_class: &str) -> Result<CompiledClassV1, ProgramError> { let casm_contract_class: CasmContractClass = serde_json::from_str(raw_contract_class)?; let sierra_version = SierraVersion::default();
is this ok...? where is try_from_json_string
used?
Code quote:
let sierra_version = SierraVersion::default();
26d288a
to
dbcfb50
Compare
5e89fc0
to
694bb8f
Compare
Benchmark movements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @noaov1, and @TzahiTaub)
dbcfb50
to
90b2b84
Compare
694bb8f
to
a040553
Compare
Benchmark movements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 22 of 28 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware, @noaov1, and @TzahiTaub)
crates/blockifier/src/execution/contract_class.rs
line 312 at r1 (raw file):
Previously, dorimedini-starkware wrote…
is this ok...? where is
try_from_json_string
used?
No, it's not okay. It is used here Here. I'll open another PR for it, and in the meantime, I'll use SierraVersion::deprecated
to avoid activating the feature on the Python gateway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should add python PR
Reviewable status: 22 of 28 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware, @noaov1, and @TzahiTaub)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1 and @TzahiTaub)
90b2b84
to
a9e3e0b
Compare
a040553
to
87285bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1 and @TzahiTaub)
a9e3e0b
to
4cb3bca
Compare
87285bf
to
4022be4
Compare
4022be4
to
0b19960
Compare
Benchmark movements: |
0b19960
to
5d8e938
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1 and @TzahiTaub)
5d8e938
to
e6dbb02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1 and @TzahiTaub)
Benchmark movements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1 and @TzahiTaub)
e6dbb02
to
3b35f20
Compare
bf2a342
to
1dfd8a7
Compare
3b35f20
to
f88449c
Compare
No description provided.