Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fix warnings #2775

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix(ci): fix warnings #2775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/blockifier/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ infra_utils.workspace = true
harness = false
name = "blockifier_bench"
path = "bench/blockifier_bench.rs"
required-features = ["testing"]

[[test]]
name = "feature_contracts_compatibility_test"
Expand Down
4 changes: 2 additions & 2 deletions crates/blockifier/src/state/stateful_compression_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,10 @@ fn test_alias_updater(
#[case] expected_alias_keys: Vec<Felt>,
#[values(0, 2)] n_existing_aliases: u8,
) {
let mut state = initial_state(n_existing_aliases);
let state = initial_state(n_existing_aliases);

// Insert the keys into the alias contract updater and finalize the updates.
let mut alias_contract_updater = AliasUpdater::new(&mut state).unwrap();
let mut alias_contract_updater = AliasUpdater::new(&state).unwrap();
for key in keys {
alias_contract_updater.insert_alias(&StorageKey::try_from(key).unwrap()).unwrap();
}
Expand Down
1 change: 0 additions & 1 deletion crates/sequencing/papyrus_consensus/src/single_height_consensus_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ use papyrus_protobuf::consensus::{ConsensusMessage, ProposalFin, ProposalInit};
use starknet_api::block::{BlockHash, BlockNumber};
use starknet_types_core::felt::Felt;
use test_case::test_case;
use tokio;

use super::SingleHeightConsensus;
use crate::config::TimeoutsConfig;
Expand Down
2 changes: 1 addition & 1 deletion scripts/run_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def cmd(self, crates: Set[str]) -> List[str]:
return ["scripts/rust_fmt.sh"] + fmt_args + ["--", "--check"]
elif self == BaseCommand.CLIPPY:
clippy_args = package_args if len(package_args) > 0 else ["--workspace"]
return ["cargo", "clippy"] + clippy_args
return ["cargo", "clippy"] + clippy_args + ["--all-targets"]
elif self == BaseCommand.DOC:
doc_args = package_args if len(package_args) > 0 else ["--workspace"]
return ["cargo", "doc", "-r", "--document-private-items", "--no-deps"] + doc_args
Expand Down
Loading