fix(ci): fix warnings #2775
fix(ci): fix warnings #2775
Conversation
|
This change is |
giladchase
force-pushed
the
gilad/fix-warnings
branch
7 times, most recently
from
20a5b8f to
c48097f
Compare
Also add required dependency for benchmarks, which cannot be run without `testing`.
giladchase
force-pushed
the
gilad/fix-warnings
branch
from
c48097f to
b7e9d61
Compare
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @giladchase)
scripts/run_tests.py line 47 at r1 (raw file):
elif self == BaseCommand.CLIPPY: clippy_args = package_args if len(package_args) > 0 else ["--workspace"] return ["cargo", "clippy"] + clippy_args + ["--all-targets"]
nice!!
solves @Itay-Tsabary-Starkware 's issue, right?
Code quote:
return ["cargo", "clippy"] + clippy_args + ["--all-targets"]crates/blockifier/Cargo.toml line 83 at r1 (raw file):
name = "blockifier_bench" path = "bench/blockifier_bench.rs" required-features = ["testing"]
why is this required? didn't the benchmark run without this before?
Code quote:
required-features = ["testing"]
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
crates/blockifier/Cargo.toml line 83 at r1 (raw file):
Previously, dorimedini-starkware wrote…
why is this required? didn't the benchmark run without this before?
Yep, with all-targets only the "default target" is run, which is everything branching out of lib.rs/main.rs.
all-targets also runs tests, benchmarks and examples.
The required-feature thing is necessary anyway though, since this benchmark doesn't compile without "testing".
scripts/run_tests.py line 47 at r1 (raw file):
Previously, dorimedini-starkware wrote…
nice!!
solves @Itay-Tsabary-Starkware 's issue, right?
It solves the warnings i had on vscode 😬
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @giladchase)
There was a problem hiding this comment.
Reviewable status:
scripts/run_tests.py line 47 at r1 (raw file):
Previously, giladchase wrote…
It solves the warnings i had on vscode 😬
Thanks, it does!
Did we have this check before, and it got removed during recently?
There was a problem hiding this comment.
Reviewable status:
There was a problem hiding this comment.
Reviewable status:
There was a problem hiding this comment.
Reviewable status:
scripts/run_tests.py line 47 at r1 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
Thanks, it does!
Did we have this check before, and it got removed during recently?
No idea
Without --all-targets they don't run on tests and benchmarks.