-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(native_blockifier): move alias constants to python #2675
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @yoavGrs)
crates/native_blockifier/src/lib.rs
line 77 at r1 (raw file):
u16::from(*MAX_NON_COMPRESSED_CONTRACT_ADDRESS), )?; py_module.add("INITIAL_AVAILABLE_ALIAS", u16::from(*MIN_VALUE_FOR_ALIAS_ALLOC))?;
What is that doing?
Code quote:
py_module.add("ALIAS_COUNTER_STORAGE_KEY", u16::from(*ALIAS_COUNTER_STORAGE_KEY))?;
py_module.add(
"MAX_NON_COMPRESSED_CONTRACT_ADDRESS",
u16::from(*MAX_NON_COMPRESSED_CONTRACT_ADDRESS),
)?;
py_module.add("INITIAL_AVAILABLE_ALIAS", u16::from(*MIN_VALUE_FOR_ALIAS_ALLOC))?;
689a198
to
214c394
Compare
298fc70
to
56cbb30
Compare
214c394
to
0f37c29
Compare
56cbb30
to
05d6ec5
Compare
0f37c29
to
4f43df7
Compare
5a4cd5f
to
8b3ee95
Compare
4f43df7
to
cd76836
Compare
8b3ee95
to
24e42e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @nimrod-starkware)
a discussion (no related file):
The python side:
https://reviewable.io/reviews/starkware-industries/starkware/36464
crates/native_blockifier/src/lib.rs
line 77 at r1 (raw file):
Previously, nimrod-starkware wrote…
What is that doing?
Adds attributes to the native_blockifier
object in python.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion
cd76836
to
1055971
Compare
24e42e2
to
6953410
Compare
1055971
to
089ef5a
Compare
6953410
to
12e35b2
Compare
089ef5a
to
0ae6d94
Compare
12e35b2
to
13a16cf
Compare
0ae6d94
to
b90ba8d
Compare
13a16cf
to
72acd34
Compare
b90ba8d
to
c8f73c0
Compare
72acd34
to
ebcae84
Compare
923d08b
to
c25a813
Compare
ebcae84
to
3f8fbe0
Compare
c25a813
to
47649ab
Compare
3f8fbe0
to
a4082d4
Compare
dd32d50
to
7efd53f
Compare
a4082d4
to
147c1c1
Compare
147c1c1
to
cab460c
Compare
7efd53f
to
43618a7
Compare
cab460c
to
f28c59f
Compare
f28c59f
to
6434eff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r2, 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)
No description provided.