Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(native_blockifier): move alias constants to python #2675

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

yoavGrs
Copy link
Contributor

@yoavGrs yoavGrs commented Dec 15, 2024

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

yoavGrs commented Dec 15, 2024

@yoavGrs yoavGrs marked this pull request as ready for review December 15, 2024 13:59
Copy link
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @yoavGrs)


crates/native_blockifier/src/lib.rs line 77 at r1 (raw file):

        u16::from(*MAX_NON_COMPRESSED_CONTRACT_ADDRESS),
    )?;
    py_module.add("INITIAL_AVAILABLE_ALIAS", u16::from(*MIN_VALUE_FOR_ALIAS_ALLOC))?;

What is that doing?

Code quote:

    py_module.add("ALIAS_COUNTER_STORAGE_KEY", u16::from(*ALIAS_COUNTER_STORAGE_KEY))?;
    py_module.add(
        "MAX_NON_COMPRESSED_CONTRACT_ADDRESS",
        u16::from(*MAX_NON_COMPRESSED_CONTRACT_ADDRESS),
    )?;
    py_module.add("INITIAL_AVAILABLE_ALIAS", u16::from(*MIN_VALUE_FOR_ALIAS_ALLOC))?;

@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch from 689a198 to 214c394 Compare December 17, 2024 07:34
@yoavGrs yoavGrs force-pushed the yoav/aliasing/constants_to_python branch from 298fc70 to 56cbb30 Compare December 17, 2024 07:34
@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch from 214c394 to 0f37c29 Compare December 17, 2024 08:24
@yoavGrs yoavGrs force-pushed the yoav/aliasing/constants_to_python branch from 56cbb30 to 05d6ec5 Compare December 17, 2024 08:24
@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch from 0f37c29 to 4f43df7 Compare December 17, 2024 08:27
@yoavGrs yoavGrs force-pushed the yoav/aliasing/constants_to_python branch 2 times, most recently from 5a4cd5f to 8b3ee95 Compare December 17, 2024 08:45
@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch from 4f43df7 to cd76836 Compare December 17, 2024 09:21
@yoavGrs yoavGrs force-pushed the yoav/aliasing/constants_to_python branch from 8b3ee95 to 24e42e2 Compare December 17, 2024 09:21
Copy link
Contributor Author

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @nimrod-starkware)


a discussion (no related file):
The python side:
https://reviewable.io/reviews/starkware-industries/starkware/36464


crates/native_blockifier/src/lib.rs line 77 at r1 (raw file):

Previously, nimrod-starkware wrote…

What is that doing?

Adds attributes to the native_blockifier object in python.

Copy link
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion

@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch from cd76836 to 1055971 Compare December 17, 2024 15:39
@yoavGrs yoavGrs force-pushed the yoav/aliasing/constants_to_python branch from 24e42e2 to 6953410 Compare December 17, 2024 15:39
@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch from 1055971 to 089ef5a Compare December 18, 2024 12:35
@yoavGrs yoavGrs force-pushed the yoav/aliasing/constants_to_python branch from 6953410 to 12e35b2 Compare December 18, 2024 12:35
@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch from 089ef5a to 0ae6d94 Compare December 18, 2024 12:52
@yoavGrs yoavGrs force-pushed the yoav/aliasing/constants_to_python branch from 12e35b2 to 13a16cf Compare December 18, 2024 12:52
@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch from 0ae6d94 to b90ba8d Compare December 18, 2024 13:48
@yoavGrs yoavGrs force-pushed the yoav/aliasing/constants_to_python branch from 13a16cf to 72acd34 Compare December 18, 2024 13:48
@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch from b90ba8d to c8f73c0 Compare December 18, 2024 15:08
@yoavGrs yoavGrs force-pushed the yoav/aliasing/constants_to_python branch from 72acd34 to ebcae84 Compare December 18, 2024 15:20
@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch 2 times, most recently from 923d08b to c25a813 Compare December 19, 2024 12:59
@yoavGrs yoavGrs force-pushed the yoav/aliasing/constants_to_python branch from ebcae84 to 3f8fbe0 Compare December 19, 2024 12:59
@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch from c25a813 to 47649ab Compare December 19, 2024 15:12
@yoavGrs yoavGrs force-pushed the yoav/aliasing/constants_to_python branch from 3f8fbe0 to a4082d4 Compare December 19, 2024 15:13
@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch 2 times, most recently from dd32d50 to 7efd53f Compare December 23, 2024 09:07
@yoavGrs yoavGrs force-pushed the yoav/aliasing/constants_to_python branch from a4082d4 to 147c1c1 Compare December 23, 2024 09:07
@yoavGrs yoavGrs changed the base branch from yoav/aliasing/contract_address to graphite-base/2675 December 23, 2024 12:34
@yoavGrs yoavGrs force-pushed the yoav/aliasing/constants_to_python branch from 147c1c1 to cab460c Compare December 23, 2024 12:55
@yoavGrs yoavGrs changed the base branch from graphite-base/2675 to main December 23, 2024 12:56
@yoavGrs yoavGrs force-pushed the yoav/aliasing/constants_to_python branch from cab460c to f28c59f Compare December 23, 2024 12:56
@yoavGrs yoavGrs force-pushed the yoav/aliasing/constants_to_python branch from f28c59f to 6434eff Compare December 23, 2024 13:47
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r2, 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

@yoavGrs yoavGrs merged commit 34c98a0 into main Dec 23, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants