Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(blockifier): pass alias contract address #2674

Merged
merged 1 commit into from
Dec 23, 2024
Merged

feat(blockifier): pass alias contract address #2674

merged 1 commit into from
Dec 23, 2024

Conversation

yoavGrs
Copy link
Contributor

@yoavGrs yoavGrs commented Dec 15, 2024

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@yoavGrs yoavGrs mentioned this pull request Dec 15, 2024
Merged
@yoavGrs Graphite App
Copy link
Contributor Author

yoavGrs commented Dec 15, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Dec 15, 2024
Merged
Merged
@yoavGrs yoavGrs marked this pull request as ready for review December 15, 2024 13:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 15, 2024 •
edited
Loading

Artifacts upload workflows:

nimrod-starkware
nimrod-starkware approved these changes Dec 15, 2024
View reviewed changes
Copy link
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 3 files reviewed, all discussions resolved

dorimedini-starkware
dorimedini-starkware requested changes Dec 15, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @yoavGrs)

a discussion (no related file):
why make the alias contract address a parameter? it is constant

yoavGrs
yoavGrs commented Dec 15, 2024
View reviewed changes
Copy link
Contributor Author

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

a discussion (no related file):

Previously, dorimedini-starkware wrote…

why make the alias contract address a parameter? it is constant

It's already in the versioned constants.

@yoavGrs yoavGrs force-pushed the yoav/aliasing/iterate_state branch from 772bd4c to 870d0cb Compare December 17, 2024 07:34
@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch from 689a198 to 214c394 Compare December 17, 2024 07:34
@yoavGrs yoavGrs force-pushed the yoav/aliasing/iterate_state branch from 870d0cb to 2879a07 Compare December 17, 2024 08:24
@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch 2 times, most recently from 0f37c29 to 4f43df7 Compare December 17, 2024 08:27
dorimedini-starkware
dorimedini-starkware approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

@yoavGrs yoavGrs force-pushed the yoav/aliasing/iterate_state branch from 2879a07 to ea681da Compare December 17, 2024 09:20
@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch from 4f43df7 to cd76836 Compare December 17, 2024 09:21
dorimedini-starkware
dorimedini-starkware approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

@yoavGrs yoavGrs force-pushed the yoav/aliasing/iterate_state branch 2 times, most recently from 7942800 to bfc9397 Compare December 17, 2024 15:39
@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch from cd76836 to 1055971 Compare December 17, 2024 15:39
@yoavGrs yoavGrs force-pushed the yoav/aliasing/iterate_state branch from bfc9397 to 829a09a Compare December 18, 2024 12:35
@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch from 1055971 to 089ef5a Compare December 18, 2024 12:35
@yoavGrs yoavGrs force-pushed the yoav/aliasing/iterate_state branch from 829a09a to 08baf87 Compare December 18, 2024 12:52
@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch from 089ef5a to 0ae6d94 Compare December 18, 2024 12:52
dorimedini-starkware
dorimedini-starkware approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

@yoavGrs yoavGrs force-pushed the yoav/aliasing/iterate_state branch from 08baf87 to 2b6e23d Compare December 18, 2024 13:48
@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch from 0ae6d94 to b90ba8d Compare December 18, 2024 13:48
dorimedini-starkware
dorimedini-starkware approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

@yoavGrs yoavGrs force-pushed the yoav/aliasing/iterate_state branch from 2b6e23d to abddc63 Compare December 18, 2024 15:08
@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch from b90ba8d to c8f73c0 Compare December 18, 2024 15:08
This was referenced Dec 18, 2024
Merged
Merged
Merged
@yoavGrs yoavGrs force-pushed the yoav/aliasing/iterate_state branch from abddc63 to e404184 Compare December 19, 2024 12:35
@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch 2 times, most recently from 923d08b to c25a813 Compare December 19, 2024 12:59
dorimedini-starkware
dorimedini-starkware approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

@yoavGrs yoavGrs force-pushed the yoav/aliasing/iterate_state branch from e404184 to 46d453e Compare December 19, 2024 15:05
@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch from c25a813 to 47649ab Compare December 19, 2024 15:12
dorimedini-starkware
dorimedini-starkware approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r7, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

@yoavGrs yoavGrs force-pushed the yoav/aliasing/iterate_state branch 2 times, most recently from de47b5a to cc26cc0 Compare December 23, 2024 08:22
@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch from 47649ab to dd32d50 Compare December 23, 2024 08:22
@yoavGrs yoavGrs force-pushed the yoav/aliasing/iterate_state branch from cc26cc0 to 344b579 Compare December 23, 2024 09:07
@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch from dd32d50 to 7efd53f Compare December 23, 2024 09:07
dorimedini-starkware
dorimedini-starkware approved these changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r8, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

@yoavGrs Graphite App
Copy link
Contributor Author

yoavGrs commented Dec 23, 2024 •
edited
Loading

Merge activity

  • Dec 23, 7:33 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 23, 7:35 AM EST: Graphite rebased this pull request as part of a merge.
  • Dec 23, 7:55 AM EST: A user merged this pull request with Graphite.

@yoavGrs yoavGrs changed the base branch from yoav/aliasing/iterate_state to graphite-base/2674 December 23, 2024 12:33
@yoavGrs yoavGrs changed the base branch from graphite-base/2674 to main December 23, 2024 12:33
@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch from 7efd53f to c7b32df Compare December 23, 2024 12:34
dorimedini-starkware
dorimedini-starkware approved these changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

@yoavGrs yoavGrs merged commit 43618a7 into main Dec 23, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nimrod-starkware nimrod-starkware nimrod-starkware approved these changes

@dorimedini-starkware dorimedini-starkware dorimedini-starkware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yoavGrs @reviewable-StarkWare @dorimedini-starkware @nimrod-starkware