chore(blockifier): add erc20 sierra contract

[AvivYossef-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[AvivYossef-starkware]

• chore(blockifier): add erc20 sierra contract #2668 : 2 dependent PRs (#2641 , #2678 ) 👈 (View in Graphite)
• refactor(blockifier): use get versioned contract class in py state reader #2614
• refactor(papyrus_rpc): get compiled class #2493
• feat(papyrus_storage): add sierra version to papyrus cache #2438
• feat(papyrus_storage): get versioned casm #2420 : 1 other dependent PR (#2421 )
• refactor(starknet_integration_tests): add sierra contract class to dummy state #2467
• feat(blockifier): get sierra contract class from feature contract #2466
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[AvivYossef-starkware]

The contact is taken from here

Reviewable status: 0 of 2 files reviewed, all discussions resolved

[github-actions]

Artifacts upload workflows:

• Started at 2024-12-15T12:28:23Z
• Started at 2024-12-15T12:34:20Z
• Started at 2024-12-15T14:05:47Z
• Started at 2024-12-15T15:28:31Z
• Started at 2024-12-15T19:05:00Z
• Started at 2024-12-15T19:35:09Z
• Started at 2024-12-15T20:07:39Z
• Started at 2024-12-15T20:19:02Z
• Started at 2024-12-17T09:17:22Z
• Started at 2024-12-17T12:10:05Z
• Started at 2024-12-17T20:08:59Z
• Started at 2024-12-17T20:09:10Z
• Started at 2024-12-17T20:09:40Z

[meship-starkware]

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 4 unresolved discussions (waiting on @AvivYossef-starkware and @dorimedini-starkware)

---

crates/blockifier/src/test_utils/contracts.rs line 294 at r1 (raw file):

        assert_ne!(self.cairo_version(), CairoVersion::Cairo0);
        // TODO (Meshi 01/01/2025): add a spacial case for ERC20 when ERC20 sierra is supported.
        assert!(!matches!(self, &Self::ERC20(CairoVersion::Cairo1(_))));

I am not sure about the comment phrasing but, I would like to have the fact that this is not the ERC20 compiled Sierra documented.

Suggestion:

 // This is not the compiled Sierra file of the existing ERC20 contract, 
 // but a file that was taken from the compiler repo of another ERC20 contract. 
 if matches!(self, &Self::ERC20(CairoVersion::Cairo1(_))) {
     return ERC20_SIERRA_CONTRACT_PATH;
}

---

crates/blockifier/src/test_utils/contracts.rs line 83 at r1 (raw file):

                                          erc20_contract_without_some_syscalls_compiled.json";
const ERC20_CAIRO1_CONTRACT_SOURCE_PATH: &str = "./ERC20/ERC20_Cairo1/ERC20.cairo";
const ERC20_CONTRACT_NAME: &str = "erc20_contract";

Suggestion:

const ERC20_SIERRA_CONTRACT_PATH: &str = "./ERC20/ERC20_Cairo1/erc20.sierra.json";

---

crates/blockifier/src/test_utils/contracts.rs line 253 at r1 (raw file):

    }

    fn get_non_erc20_base_name(&self) -> &str {

Change the name if it also returns the ERC20 contract

Code quote:

get_non_erc20_base_name

---

crates/blockifier/src/test_utils/contracts.rs line 264 at r1 (raw file):

            Self::CairoStepsTestContract => CAIRO_STEPS_TEST_CONTRACT_NAME,
            Self::SierraExecutionInfoV1Contract(_) => EXECUTION_INFO_V1_CONTRACT_NAME,
            Self::ERC20(_) => ERC20_CONTRACT_NAME,

Suggestion:

 Self::ERC20(_) => unreachable!(),

[AvivYossef-starkware]

Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware and @meship-starkware)

---

crates/blockifier/src/test_utils/contracts.rs line 253 at r1 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

Change the name if it also returns the ERC20 contract

Done.

---

crates/blockifier/src/test_utils/contracts.rs line 294 at r1 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

I am not sure about the comment phrasing but, I would like to have the fact that this is not the ERC20 compiled Sierra documented.

Done.

[meship-starkware]

Reviewed all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @dorimedini-starkware)

---

crates/blockifier/feature_contracts/cairo1/sierra/erc20_contract.sierra.json line 49 at r2 (raw file):

        "0x2ee1e2b1b89f8c495f200e4956278a4d47395fe262f27b52e5865c9524c08c3",
        "0x3288d594b9a45d15bb2fcb7903f06cdb06b27f0ba88186ec4cfaa98307cb972",
        "0x11",

Move this file to crates/blockifier/ERC20/ERC20_Cairo1

[meship-starkware]

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @dorimedini-starkware)

[dorimedini-starkware]

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)

[AvivYossef-starkware]

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @meship-starkware)

---

crates/blockifier/feature_contracts/cairo1/sierra/erc20_contract.sierra.json line 49 at r2 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

Move this file to crates/blockifier/ERC20/ERC20_Cairo1

ops

[meship-starkware]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

[dorimedini-starkware]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

[AvivYossef-starkware]

Merge activity

• Dec 17, 3:08 PM EST: A user started a stack merge that includes this pull request via Graphite.
• Dec 17, 3:10 PM EST: Graphite rebased this pull request as part of a merge.
• Dec 17, 3:26 PM EST: A user merged this pull request with Graphite.